Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example strategies on foreign markets #125

Closed
wants to merge 7 commits into from
Closed

Conversation

enzbus
Copy link
Collaborator

@enzbus enzbus commented Jan 5, 2024

Add London / few Europe / Tokyo strategies, same model of current 3 in examples/strategies.

Issues:

  • alternative cash keys need testing, improvements in fred data cleaning
  • yahoo finance data can be buggy on non-us stocks, needs refactoring and improving data cleaning

Idea:

  • factor data.py in data/ submodule;
  • inherit YahooFinance from OHLCV class
  • refactor data cleaning logic (separate logical steps) in OHLCV, reused with other sources

@coveralls
Copy link

coveralls commented Jan 5, 2024

Coverage Status

coverage: 98.938%. remained the same
when pulling d745b00 on foreign_strategies
into 47084ed on master.

@enzbus enzbus mentioned this pull request Jan 22, 2024
@enzbus
Copy link
Collaborator Author

enzbus commented Jan 22, 2024

Replaced by #127.

@enzbus enzbus closed this Jan 22, 2024
@enzbus enzbus deleted the foreign_strategies branch July 13, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants