Fix HRF sampling to maintain precise timing #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The HRF sampling calculation in
getcanonicalhrf()
was truncating the end time to an integer, which could occasionally result in losing a sampling point. This caused inconsistencies between the length of the assumed HRF and the HRF library.Solution
Remove the
int()
cast from the sampling end time calculation to maintain floating-point precision:Why
(hrf.shape[0]-1)*trold
is a precise time in seconds (e.g., 68.8s)int()
would truncate this to 68s, potentially losing a sampling pointTesting
Debug output confirms correct sampling:
No changes to the underlying HRF computation, only to the sampling precision.