-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to the COLMAP head. Use FetchContent for PoseLib and COLMAP #98
Conversation
With which Python version did you build it in your tests? The compilation of PoseLib is failing for me with Python 3.10:
Upgrading setuptools to the latest version doesn't help. |
The previous issue was fixed here (due to copy construction behavior in pybind11): 6e14755. Now both quickstarts work for me. Will add the quickstart tests to CI test in the future PR. |
One thing to mention is that the parallelization for fitting 3D lines in the fitnmerge pipeline is currently broken. However, it is not the bottleneck so we could live with it: 2957ebf. Will look into it in later days. |
This works in my test after installation. More tests are appreciated.
Will add the installation test into CI for the next step (in a separate PR after this is merged).