Bugfix for upgrading COLMAP + Adapt to the new pycolmap interface for localization #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
B1ueber2y
commented
Dec 12, 2024
•
B1ueber2y
commented
- Install hloc from a temporary upstream here: https://github.com/B1ueber2y/Hierarchical-Localization/tree/upstream/limap. Will update when Adapt to the new pycolmap interface Hierarchical-Localization#446 gets merged.
- Fix documentations for inlier_mask
- Crucial bug fix for the colmap upgrade 04987c4. In localization the camera needs to be set to PINHOLE for the limap implementation.
B1ueber2y
changed the title
MarkYu98
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.