Skip to content

Commit

Permalink
Add isort, merge check runs into one
Browse files Browse the repository at this point in the history
  • Loading branch information
sarlinpe committed Oct 8, 2023
1 parent 1709021 commit 7e990a8
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 13 deletions.
18 changes: 6 additions & 12 deletions .github/workflows/code-quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,24 +8,18 @@ on:
pull_request:
types: [ assigned, opened, synchronize, reopened ]
jobs:
formatting-check:
name: Formatting Check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: psf/black@stable
with:
jupyter: true
linting-check:
name: Linting Check
check:
name: Format and Lint Checks
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: "3.10"
python-version: '3.10'
cache: 'pip'
- run: python -m pip install --upgrade pip
- run: python -m pip install .
- run: python -m pip install --upgrade flake8
- run: python -m pip install --upgrade flake8 isort black
- run: python -m flake8 . --exclude build/
- run: python -m isort . --check-only --diff
- run: python -m black . --check --diff
5 changes: 4 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,13 @@ extra = [
"deeplsd @ git+https://github.com/cvg/DeepLSD.git",
"homography_est @ git+https://github.com/rpautrat/homography_est.git",
]
dev = ["black", "flake8", "jupyter"]
dev = ["black", "flake8", "isort", "jupyter"]

[tool.setuptools.packages.find]
include = ["gluefactory*"]

[tool.setuptools.package-data]
gluefactory = ["datasets/megadepth_scene_lists/*.txt", "configs/*.yaml"]

[tool.isort]
profile = "black"

0 comments on commit 7e990a8

Please sign in to comment.