Defaults for DATASOURCE_USER & DATASOURCE_PASSWORD to None #293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mongo url without user/password after #291.
Cause
The #291 adds this if statement:
This condition is never met, because those variables have default values and it is impossible to explicitly set them to
None
, asNone
from an environment variable is treated as a string instead of Python None Keyword.Before
DATASOURCE_USER
DATASOURCE_PASSWORD
self._datasource_connection_details
{'host': 'mongodb://cvexplore:[email protected]:27017'}
None
None
{'host': 'mongodb://None:[email protected]:27017'}
After
DATASOURCE_USER
DATASOURCE_PASSWORD
self._datasource_connection_details
{'host': 'mongodb://127.0.0.1:27017'}
cvexplore
password
{'host': 'mongodb://cvexplore:[email protected]:27017'}