Use windows line endings for windows hosts file #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -208,7 +208,9 @@ def new_content | |||
| entries = hostsfile_header | |||
| entries += unique_entries.map(&:to_line) | |||
| entries << '' | |||
| entries.join("\n") | |||
| line_ending = "\n" | |||
| line_ending = "\r\n" if node['platform_family'] == 'windows' | |||
There was a problem hiding this comment.
We could combine this line (ex. line_ending = node['platform_family'] == 'windows' ? "\r\n" : "\n") so that we don't assign line_ending twice, in the uncommon case.
There was a problem hiding this comment.
sounds good to me, ruby isn't my first language :)
|
+1 |
Closed
|
+1 |
|
Can I help somehow with merging this change? |
|
👍 |
|
Judging by the age of some of the open PRs, is this repo even supported anymore? |
|
Anything you can help with @tas50 as I see you fixed some of the previously failing Travis builds? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.