-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Create readme file to help with building and running sample apps #370
Conversation
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
Apps/README.md
Outdated
|
||
## Connect the app to a workspace in Customer.io | ||
|
||
Make a copy of `env.sample.js` by running `cp env.sample.js env.js` at sample app root directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to copy Env.swift.example
as well, otherwise iOS apps will not compile. Also, there are no instructions for signing iOS app, adding them will be helpful for anyone from CIO setting it up the first time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are you suggesting for iOS signing? Downloading the provisioning profiles you mean? Otherwise, everything should already be setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
This PR adds a readme file to our sample apps to help with instructions for building and running sample apps.