Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use actionConfig.haptic in handleAction #62

Closed
wants to merge 1 commit into from
Closed

Use actionConfig.haptic in handleAction #62

wants to merge 1 commit into from

Conversation

bernikr
Copy link

@bernikr bernikr commented Apr 5, 2022

There is inconsistent behavior between the handleAction and handleClick methods. Both take an actionConfig (which contains a haptic option) as an argument, but handleAction ignores the haptic option and triggers success haptics without any option of turning them off.

This PR changes this behavior to correctly use the actionConfig.haptic in the handleAction method.

Related: #61

@bernikr bernikr closed this by deleting the head repository Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bernikr