Create SkipCutsceneON.js #57
Conversation
Another restored script part of cursey#46. This script causes any cutscene to break, automatically skipping it as a result. This might not be fitting for some people, so this should go to disabled.txt. When I used cutscene skip before, it was mostly for grinding purposes (farming for a pass, doing tournament), and afterwards I would turn cutscenes back on. With that in mind, I created an OFF file to revert the changes without having to restart the client. However, this is very savvy. I propose that Kanan should have a switch function, a way to patch a variable to a different value through the CMD console. For example, this is I would have wanted the file to work: var pattern = scan('?? ?? ?? 75 05 39 ?? ?? ?? ?? ?? ?? E0'); patch(pattern.add(3), 0x75); patch.on{pattern.add(3), 0xEB); patch.off{pattern.add(3), 0x75); By default, the script would be off. In the console, you would type "SkipCutscene.js on" to execute the script again on the switch titled "on". If I ever find a way to change default ranged attack, could make multiple switches for everyone of them (ex DefaultRangedAttack.js Magnum) I understand this might take a while, so I decide to go with this ON and OFF thing for the time being. If you don't like it, reject the OFF file.
Refer to cursey#57
|
Hmm, yeah I am still deciding the best way to handle enabling/disabling scripts during run-time. It's been requested in issue #28 . I've already made it so scripts send back the patch information to As for merging this request, I would prefer if it was just |
|
I'm actually not able to get this to work the way you have it. Can you double check? The pattern works in CE although the patch seems to just break cut scenes (tested in Alby dungeon). Kanan gives an error when searching for the pattern, probably because it starts with wildcards. |
|
You've thoroughly tested it, its all exactly as you said. I tested this on CE, I've done the test in the Dunbarton library with those fortune teller orbs and it worked just fine. However, now that I cleared Alby with it, I see what you mean... it completely broke it. I'll try to fix this tomorrow. I'm sorry for not properly checking it. P.S. I didn't know about the wildcards in the beginning rule, thank you. |
|
No worries. I check all PR's before I merge because I know this kinda thing can happen. |
|
From my understanding there seems a unique trigger when it comes to boss rooms, the world disappears then reappears again. Breaking the cutscene leaves the impression on the client you're still watching it therefore the world is not loading again. I can't seem to figure it out (I'm really bad at assembly), and I'm getting tired of Alby, so you can close this request unless somebody else wants to give it a go. mod_sharker r234: |
Another restored script part of #46. Originally created by Step29.
This script causes any cutscene to break, automatically skipping it as a result. This might not be fitting for some people, so this should go to disabled.txt.
When I used cutscene skip before, it was mostly for grinding purposes (farming for a pass, doing tournament), and afterwards I would turn cutscenes back on. With that in mind, I created an OFF file to revert the changes without having to restart the client.
However, this is very savvy. I propose that Kanan should have a switch function, a way to patch a variable to a different value through the CMD console.
For example, this is I would have wanted the file to work:
By default, the script would be off. In the console, you would type "SkipCutscene.js on" to execute the script again on the switch titled "on". If I ever find a way to change default ranged attack, could make multiple switches for each one of them (ex DefaultRangedAttack.js Magnum)
I understand this might take a while, so I decide to go with this ON and OFF thing for the time being. If you don't like it, reject the OFF file.