Extending React.Component rather than using createClass #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evancz Can this be merged? :) |
|
I guess you shouldn't use uncompiled ES6 as it will break a lot of 3rd party deps, should export a compiled version. |
|
This seems to be obsolete now that #11 has merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With React 16 coming soon and removing
createClassfrom the main React package I just re-implemented the component extendingReact.Component.I saw PR #11 trying to solve the same issue by adding
create-react-classas a dependency. I reckon most people are running node v4+ so probably no need for adding that dependency.I've simply re-implemented it "as is" without questioning the logic but if we get rid of the life-cycle method
shouldComponentUpdatethis could simply be a pure function.