fix: failure reasons display #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamestelfer
force-pushed
the
better-errors
branch
from
db75ce0 to
e580980
Compare
The message will include the reason for failure on each platform.
Allows for other environment variables to be read from the agent context.
jamestelfer
force-pushed
the
better-errors
branch
from
e580980 to
e1780ab
Compare
Also add the name of the image that failed: far easier to find the issue.
Avoids a Getenv call buried deep in the mire.
This API has been present for some time, no need to use a cast.
jamestelfer
force-pushed
the
better-errors
branch
from
e1780ab to
8f4d72e
Compare
ctgardner
previously approved these changes
Jun 23, 2024
|
ctgardner
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the display of failure reasons on each platform and adds support for agent test mode. The failure reasons will now be shown in the output, making it easier to identify the issues. Additionally, the agent test mode allows for other environment variables to be read from the agent context.
#56 should be merged first