Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message to be shown when formatting Error #446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Feasul
Copy link
Contributor

@Feasul Feasul commented Apr 9, 2015

In case an Error to be formatted has a message, add it on top of the error stack. Sometimes error message is more useful than error stack, which is oftentimes doesn't have anything except when.js methods chain.

In case an Error to be formatted has a message, add it on top of the error stack. Sometimes error message is more useful than error stack, which is oftentimes doesn't have anything except when.js methods chain.
@sompylasar
Copy link

@Feasul Usually the stack's first line contains the error name and the message. In which environments this is not the case?

@Feasul
Copy link
Contributor Author

Feasul commented Apr 9, 2015

@sompylasar I was observing that behavior under iOS 8 WebView. Though you are right, turns out there's no constant behavior among the different environments. I did a quick check on Firefox, Chrome, Safari (Mac) and IE(Win) and only Chrome and IE have error message in stack trace. This patch is obviously unacceptable until it accounts for all the possibilities there are.

@briancavalier
Copy link
Member

@Feasul Yeah, unfortunately, there's very little consistency for stack traces across envs. We do the best we can without bloating the code too much. If you can find a way to bring the iOS error reporting in line with the other envs without too much added code, we'd love to have your PR :)

@briancavalier
Copy link
Member

Ping @Feasul. Are you still interested in investigating ways to cover all the possible cases, or should we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants