Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c, cpp]: support VERSION file for CMake ABI versioning #328

Merged
merged 4 commits into from
Nov 30, 2024

Conversation

chybz
Copy link
Contributor

@chybz chybz commented Nov 23, 2024

🤔 What's changed?

⚡️ What's your motivation?

make sure ABI is versioned for shared libraries

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)
  • 💥 Breaking change (incompatible changes to the API)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@chybz chybz self-assigned this Nov 23, 2024
@@ -22,7 +22,7 @@ public static string NameOf(Rule rule)
#include <ostream>
#include <string_view>

namespace gherkin {
namespace cucumber::gherkin {
Copy link
Contributor

@mpkorstanje mpkorstanje Nov 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not a breaking change?

@mpkorstanje
Copy link
Contributor

Please also update the CHANGELOG.md so things are properly documented on release.

@chybz
Copy link
Contributor Author

chybz commented Nov 30, 2024

@mpkorstanje I'm going to merge. Can you please activate the VERSION automatic update for gherkin/cpp and messages/cpp ?

@chybz chybz merged commit 13cc4b3 into main Nov 30, 2024
6 checks passed
@chybz chybz deleted the cpp/abi-soversion branch November 30, 2024 11:11
@mpkorstanje
Copy link
Contributor

It's already merged. cucumber/polyglot-release#104

Question though, is the change in namespace that you included breaking in a Semver context? Doesn't matter for merging but does matter when it comes to deciding the next version number.

@chybz
Copy link
Contributor Author

chybz commented Nov 30, 2024

TLDR: yes. Sincerely hope that's not overly problematic.

It is from a pure compilation standpoint, but function signatures are exactly the same as before, so this should be a minimal hassle for the (no more than 2 people I think) current cpp user-base.

@mpkorstanje
Copy link
Contributor

Okay cheers! I didn't see your edit until now.

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Nov 30, 2024

And no problem! Version numbers are relatively cheap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please version the ABI for C shared libraries
2 participants