-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c, cpp]: support VERSION file for CMake ABI versioning #328
Conversation
@@ -22,7 +22,7 @@ public static string NameOf(Rule rule) | |||
#include <ostream> | |||
#include <string_view> | |||
|
|||
namespace gherkin { | |||
namespace cucumber::gherkin { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not a breaking change?
Please also update the |
085179f
to
0069280
Compare
@mpkorstanje I'm going to merge. Can you please activate the |
It's already merged. cucumber/polyglot-release#104 Question though, is the change in namespace that you included breaking in a Semver context? Doesn't matter for merging but does matter when it comes to deciding the next version number. |
TLDR: yes. Sincerely hope that's not overly problematic. It is from a pure compilation standpoint, but function signatures are exactly the same as before, so this should be a minimal hassle for the (no more than 2 people I think) current cpp user-base. |
Okay cheers! I didn't see your edit until now. |
And no problem! Version numbers are relatively cheap. |
🤔 What's changed?
⚡️ What's your motivation?
make sure ABI is versioned for shared libraries
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.