Reinstate the pre-export hook to the original place and add a pre-tem… #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -184,8 +184,8 @@ func (self *Builder) Run(ui packer.Ui, hook packer.Hook, cache packer.Cache) (pa | |||
| new(common.StepProvision), | |||
| new(xscommon.StepShutdown), | |||
| &xscommon.StepExecuteHostScripts{ | |||
| ScriptType: "pre-export", | |||
| LocalScripts: self.config.PreExportHostScripts, | |||
| ScriptType: "pre-template", | |||
There was a problem hiding this comment.
How about post-shutdown? There are more steps between this and new(xscommon.StepConvertToTemplate),
There was a problem hiding this comment.
pre-template would work if it were to be called right before the templating line. Of course this is mostly for Dinesh so I'm not blocking the current form
There was a problem hiding this comment.
I understand, I let Dinesh to comment since it's the place that he wanted previously. Maybe we need a post-shutdown and a pre-template (+ pre-export as before).
There was a problem hiding this comment.
I am ok with keeping it as pre-shutdown i need the step before vifs are destroyed and converted to a template
|
Following up on this. Can we get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reinstate the pre-export hook to the original place and add a pre-template hook