-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dimension to gain mask if ndim equals 1 #72
base: master
Are you sure you want to change the base?
Conversation
Hi @mackaiver |
Sorry I was mixing ctapipe master version and v0.6.2. |
I did this on ctapipe v0.6.2. The dl1-data-handler does not work on the current ctapipe version I as far as I know. Ever since the |
Yes many changes in ctapipe are not compatible anymore (e.g. gain selection that's why I was confused at first). Could you rather open an issue and tell me (if you know) for which cameras it fails please? |
Ok. Good idea. Unfortunately I'm rather busy at the moment. Maybe @riwim has some time to spare? |
I will definitely try. As of now, I have just been a user of the handler. It will take some time for me to become acquainted with the project and be able to draft a reasonable issue for the very case. Edit: I'm sorry but I can't find out how to test for this problem. |
Fixes an error which occurs when the
gain_selector.select_gains
returns an unexpected dimension.Lets call this a hotfix since I have no idea what this is doing exactly. And why.