Amaslows addv12mods #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comments out the version setting to 3.1.0 as this oci provider version does not support terraform v12. removing it allows terraform init to pull the latest oci plugin that works with v12.
reset some vaules back to the original project defaults, removes some validation skip that show a warning in v12 stating they are no longer done and don't need skipping.
removed version pin to oci 3.1.0 provider, removed deprecated skips on s3 checks
v11 syntax: compartment_id = "${data.terraform_remote_state.common.network_compartment}"
v12 syntax: compartment_id = data.terraform_remote_state.common.outputs.network_compartment
v12 syntax: compartment_id = data.terraform_remote_state.common.outputs.network_compartment
remove 3.1.0 oci plugin version pinning, fix remote_state references to include outputs
Fixed subnet references to work with v12:
subnet_id = data.terraform_remote_state.network.outputs.vault_subnets[0][lookup(var.consul_node_to_ad_map, count.index, 1) - 1]
vault_subnets for some reason is now a tuple of tuples so needs an extra [0] for first tuple:
"vault_subnets": {
"value": [
[
"ocid1.subnet.oc1.iad.cba",
"ocid1.subnet.oc1.iad.bca",
"ocid1.subnet.oc1.iad.abc"
]
],
v12 syntax: subnet_id = data.terraform_remote_state.network.outputs.vault_subnets[0][count.index] - also fixed display_name and hostname_lable to 'vault' from consul
first change only fixed the vnic hostname_label (my mistake)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Errata:
v12 Changes: