first steps towards bypassing setImage with a custom file input #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! sorry for the delay |
|
Thanks for merging! Any chance this gets into a release soon? |
|
Was hoping to have #175 fixed first - give me few more days and I will publish it |
|
I know you were looking to do a 0.9.0 release, could there potentially be another 0.8.7 release for this PR, as well as all the other recent ones? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't really expect this to be taken as is, but it did work for me, and almost certainly did not break anything else, so maybe it's good enough for a first cut. This problem actively impeded my progress due to this issue, and while there are some angular hacks available to fix it, they are messy and this "just worked."
Given that
imageis already taken, I opted forinputImage.