Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make canvas transparent #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make canvas transparent #55

wants to merge 2 commits into from

Conversation

Slowyn
Copy link

@Slowyn Slowyn commented May 3, 2018

Problem:
image
Current implementation doesn't allow to create qr-code with transparent backgrounds.

This PR turns transparency by default.

@yhsiang
Copy link

yhsiang commented Dec 10, 2018

@cssivision will you merge this?

This PR fixed our problem, when we have two themes, light and dark.

QRCode view will break in dark view, so we need make background color be transparent.

Especially we have this problem on android phone.

@balthazar
Copy link

Published react-native-qrcode-transparent based on this PR while we wait

@Slowyn
Copy link
Author

Slowyn commented Dec 20, 2018

Guys, sad news, the repo is officially no longer maintained. Someone should take a project at his hand.
@balthazar It would be nice if you could maintain and develop your fork further.
You should make PR with the link from this project to yours.
@cssivision Are you agree to this and will you accept the incoming PR?

@balthazar
Copy link

Unfortunately not possible for me, as I already have a couple repos to maintain.

@Slowyn
Copy link
Author

Slowyn commented Dec 20, 2018

Well, probably I can take maintenance. We'll see.

@cssivision
Copy link
Owner

that is great, if someone can take the maintenance.

@AkshatGiri
Copy link

AkshatGiri commented Jul 17, 2019

I can commandeer the repo if the the owner is okay with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants