Small performance follow-up to 9b7b248

css4j · Dec 18, 2024 · eab6940 · eab6940
1 parent 004b713
commit eab6940
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/echosvg-parser/src/main/java/io/sf/carte/echosvg/parser/AbstractParser.java b/echosvg-parser/src/main/java/io/sf/carte/echosvg/parser/AbstractParser.java
@@ -383,6 +383,7 @@ void handleCalc() throws IOException {
 		char[] calcUCRef = { 'A', 'L', 'C', '(' };
 		char[] calcBuf = new char[4];
 
+		// For performance, ignore how many bytes were read
 		reader.read(calcBuf);
 
 		if (equalsAny(calcLCRef, calcUCRef, calcBuf)) {
@@ -393,10 +394,8 @@ void handleCalc() throws IOException {
 	}
 
 	private static boolean equalsAny(char[] lcRef, char[] ucRef, char[] buf) {
-		// Assume that lcRef and ucRef have the same length
-		if (lcRef.length != buf.length) {
-			return false;
-		}
+		// It's up to the caller to make sure that buf, lcRef and ucRef have the same length
+		assert lcRef.length == buf.length;
 
 		for (int i = 0; i < lcRef.length; i++) {
 			char c = buf[i];