Skip to content

Commit

Permalink
pythongh-109960: Remove test_pty timeout of 10 seconds (python#110058)
Browse files Browse the repository at this point in the history
In 2003, test_pty got a hardcoded timeout of 10 seconds to prevent
hanging on AIX & HPUX "if run after test_openpty":
commit 7d81452. Since 2003, test_pty
was no longer reported to hang on AIX. But today, the test can fail
simply because a CI is busy running other tests in parallel.
The timeout of 10 seconds is no longer needed, just remove it.
Moreover, regrtest now has multiple built-in generic timeout
mecanisms.
  • Loading branch information
vstinner authored Sep 29, 2023
1 parent b488c0d commit 5fdcea7
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions Lib/test/test_pty.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,17 +80,9 @@ def expectedFailureIfStdinIsTTY(fun):
# because pty code is not too portable.
class PtyTest(unittest.TestCase):
def setUp(self):
old_alarm = signal.signal(signal.SIGALRM, self.handle_sig)
self.addCleanup(signal.signal, signal.SIGALRM, old_alarm)

old_sighup = signal.signal(signal.SIGHUP, self.handle_sighup)
self.addCleanup(signal.signal, signal.SIGHUP, old_sighup)

# isatty() and close() can hang on some platforms. Set an alarm
# before running the test to make sure we don't hang forever.
self.addCleanup(signal.alarm, 0)
signal.alarm(10)

# Save original stdin window size.
self.stdin_dim = None
if _HAVE_WINSZ:
Expand All @@ -101,9 +93,6 @@ def setUp(self):
except tty.error:
pass

def handle_sig(self, sig, frame):
self.fail("isatty hung")

@staticmethod
def handle_sighup(signum, frame):
pass
Expand Down

0 comments on commit 5fdcea7

Please sign in to comment.