Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables auth by default for sidecar and manager communication #740

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

bipuladh
Copy link
Contributor

@bipuladh bipuladh commented Jan 6, 2025

No description provided.

cmd/manager/main.go Outdated Show resolved Hide resolved
sidecar/main.go Outdated Show resolved Hide resolved
Copy link
Member

@black-dragon74 black-dragon74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

Copy link
Member

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

we should enable the security features by default and update all the consumers with required RBAC's.

@Madhu-1
Copy link
Member

Madhu-1 commented Jan 7, 2025

cc @nixpanic PTAL as you approved the initial PR where the flag was disabled by default.

Copy link
Collaborator

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This is nice to have in the next release. Consumers of csi-addons that deploy the controller and/or sidecar will have some time to make changes (if they want).

Copy link

mergify bot commented Jan 9, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@Madhu-1
Copy link
Member

Madhu-1 commented Jan 9, 2025

@Mergifyio rebase

Copy link

mergify bot commented Jan 9, 2025

rebase

✅ Branch has been successfully rebased

@Madhu-1 Madhu-1 force-pushed the enable-by-default branch from a1e8e46 to 38c1551 Compare January 9, 2025 14:44
@Madhu-1
Copy link
Member

Madhu-1 commented Jan 9, 2025

@Mergifyio requeue

Copy link

mergify bot commented Jan 9, 2025

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@Madhu-1
Copy link
Member

Madhu-1 commented Jan 9, 2025

@Mergifyio queue

Copy link

mergify bot commented Jan 9, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at dd9be53

@mergify mergify bot merged commit dd9be53 into csi-addons:main Jan 9, 2025
14 of 15 checks passed
Copy link

mergify bot commented Jan 9, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants