-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All required features and fixes for the OC/NC ScienceMesh apps #4115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t's api Signed-off-by: MohammadReza vahedi <[email protected]>
Signed-off-by: MohammadReza vahedi <[email protected]>
Signed-off-by: MohammadReza vahedi <[email protected]>
…t's api Signed-off-by: MohammadReza vahedi <[email protected]>
Signed-off-by: MohammadReza vahedi <[email protected]>
Signed-off-by: MohammadReza vahedi <[email protected]>
Signed-off-by: MohammadReza vahedi <[email protected]>
Signed-off-by: MohammadReza vahedi <[email protected]>
Signed-off-by: MohammadReza vahedi <[email protected]>
…to sciencemesh-testing
* fix: GetSentShareByToken * fix: ListShares test * fix: ListReceivedShares test Signed-off-by: Mohammad Mahdi Baghbani Pourvahid <[email protected]> * fix: GetReceivedShare test Signed-off-by: Mohammad Mahdi Baghbani Pourvahid <[email protected]> * fix: UpdateReceivedShare test Signed-off-by: Mohammad Mahdi Baghbani Pourvahid <[email protected]> * fix: GetMD test Signed-off-by: Mohammad Mahdi Baghbani Pourvahid <[email protected]> * fix: GetUserByClaim test Signed-off-by: Mohammad Mahdi Baghbani Pourvahid <[email protected]> * fix: temporary comment out assertMetadata integration test Signed-off-by: Mohammad Mahdi Baghbani Pourvahid <[email protected]> * fix: linter error on import duplicate Signed-off-by: Mohammad Mahdi Baghbani Pourvahid <[email protected]> * fix: ListFolder test * fix: ListFolder test * fix: lint --------- Signed-off-by: Mohammad Mahdi Baghbani Pourvahid <[email protected]>
…r GetMD and ListFolder
gmgigi96
requested changes
Sep 8, 2023
This was referenced Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #3949 and #3967. It includes all changes from
master
as of today. The driver from #3967 is included (renamed fromapi
tonextcloud
), but not enabled.Tasks to be completed prior to merge:
examples/sciencemesh
folder w.r.t. the other examplesFurther tasks (can be done after merge):
Tests:
❌ OC -> Reva -> OC for a read-only share - broken because of Persistency of incoming OCM shares - incorrect handling of read-only folders sciencemesh/nc-sciencemesh#45
❌ OC -> Reva -> NC for a read-only share - broken
❌ CERNBox -> Reva -> OC for a read-only share - broken
The latter two tests follow the latest findings in sciencemesh/nc-sciencemesh#42