Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/removing fairsale #459

Merged
merged 8 commits into from
Sep 13, 2021
Merged

Feature/removing fairsale #459

merged 8 commits into from
Sep 13, 2021

Conversation

rossneilson
Copy link
Member

@rossneilson rossneilson commented Sep 8, 2021

Description

Removing fairsale for MVP 0.1.1 release
Also removing contracts to use exported files from aqua-js, will add this to dev after also (I forgot in the previous PR)
Updated xdai subgraph endpoint

Motivation and Context

Closes #445

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rossneilson rossneilson added the enhancement New feature or request label Sep 8, 2021
@rossneilson rossneilson added this to the MVP Pre-Production milestone Sep 8, 2021
@rossneilson rossneilson self-assigned this Sep 8, 2021
@github-actions github-actions bot temporarily deployed to feature-removing-fairsale September 8, 2021 10:08 Inactive
@github-actions github-actions bot temporarily deployed to feature-removing-fairsale September 8, 2021 11:31 Inactive
@mprasanjith
Copy link
Contributor

mprasanjith commented Sep 8, 2021

Two things we'll need to fix. I don't think these were introduced in this PR, but I'm leaving this comment here for visibility.

When you do a purchase, the order shows up fine, like below.

image

Let's keep this in mind, and go back to all sales. Notice that the sale card doesn't show any purchase data.

Now, let's refresh the page. The card now has my purchases shown nicely.

image

So first issue; We need to update the card to show the token purchases before refreshing the page. Just a minor tweak.

Now let's open the sale page again.

Screenshot 2021-09-08 at 19-11-14 Fixed Price Sale Token – FPST Aqua

Now the order history doesn't show up at all. That's the second issue.

I'll create separate issues for these for tracking.

PS: Issues created: #460 / #461

@mprasanjith
Copy link
Contributor

Btw do we have any idea why the Netlify builds failed? I don't think we should care, but just in case.

@rossneilson
Copy link
Member Author

Nice spotting those bugs, we'll get them fixed for MVP
On netlify, I was thinking it was maybe because we are merging to main and not develop? But yeah, not important we could probably remove netlify

@github-actions github-actions bot temporarily deployed to feature-removing-fairsale September 9, 2021 15:45 Inactive
@mprasanjith
Copy link
Contributor

Updated the PR to fix #461.

@github-actions github-actions bot temporarily deployed to feature-removing-fairsale September 9, 2021 18:26 Inactive
@rossneilson
Copy link
Member Author

rossneilson commented Sep 9, 2021

For some reason, not sure if this was just something we didn't test recently, sales that I participated in but failed to be successful sales were not appearing in the closed tab under my sales or other sales.
To fix this I removed the filtering on successful sales for the claims section and turned the "Bids won" into "Participated sales".
In future we should add different types of token claims here for failed and successful.

I will add this to dev branch also post merge here

@github-actions github-actions bot temporarily deployed to feature-removing-fairsale September 9, 2021 18:31 Inactive
@github-actions github-actions bot temporarily deployed to feature-removing-fairsale September 10, 2021 17:33 Inactive
@github-actions github-actions bot temporarily deployed to feature-removing-fairsale September 13, 2021 10:05 Inactive
@rossneilson rossneilson merged commit ca3dad7 into main Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants