Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use package.json:files instead .npmignore #30

Merged
merged 1 commit into from
Apr 9, 2017
Merged

Use package.json:files instead .npmignore #30

merged 1 commit into from
Apr 9, 2017

Conversation

fanatid
Copy link
Member

@fanatid fanatid commented Apr 9, 2017

Extracted from #19

@jprichardson
Copy link
Member

On a number of my repos where I use files, npm doesn't grab the README even though it's suppose to according to the npm spec. See: https://www.npmjs.com/package/bip44-constants

Do you think that'll happen here?

@fanatid
Copy link
Member Author

fanatid commented Apr 9, 2017

That very strange that bip44-constants was published without README...
You can check what will be published with npm pack
cryptocoinjs/keccak also uses files and published with README: https://www.npmjs.com/package/keccak

@jprichardson jprichardson merged commit e7e4308 into master Apr 9, 2017
@fanatid fanatid deleted the remove-npmignore branch April 9, 2017 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fanatid @jprichardson