Problem: query blocks before enable feemarket module get nil pointer error

[mmsqe]

For more info

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

• Bug Fixes

  • Resolved a nil pointer error when querying blocks prior to the activation of the feemarket module.

• Improvements

  • Upgraded rocksdb dependency to version v9.8.4.

• Chores

  • Updated Go module version to go 1.23.1 and modified various dependencies for better compatibility and performance.

[coderabbitai]

Walkthrough

The pull request includes updates to the CHANGELOG.md and go.mod files. The CHANGELOG.md now documents a bug fix for a nil pointer error when querying blocks before the feemarket module activation and notes the upgrade of the rocksdb dependency to version v9.8.4. The go.mod file has been revised to update the Go module version to go 1.23.1 and to modify several dependencies, including their versions and replacements, ensuring compatibility with the latest updates in the Cosmos SDK ecosystem.

Changes

File	Change Summary
CHANGELOG.md	- Added bug fix for nil pointer error when querying blocks prior to feemarket module activation.
	- Updated rocksdb dependency to version v9.8.4.
go.mod	- Updated Go module version to go 1.23.1.
	- Modified several dependencies, including updates and replacements for cosmossdk.io modules and others.

Possibly related PRs

• Problem: query blocks before enable feemarket module get nil pointer error #1714: This PR includes a bug fix related to avoiding a nil pointer error when querying blocks prior to the activation of the feemarket module, which is directly related to the changes made in the main PR.
• Problem: rocksdb 9.8.4 is not used #1712: This PR discusses an upgrade of the rocksdb dependency to version v9.8.4, which is also mentioned in the main PR as part of the changelog updates.

Suggested reviewers

• JayT106
• calvinaco

🐰 In the changelog, a tale unfolds,
Of nil pointers fixed and rocksdb bold.
Dependencies shift, like leaves in the breeze,
With updates so fresh, they aim to please.
Hopping along, we celebrate this feat,
In the code's garden, where changes are sweet! 🌼

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint (1.62.2)

level=warning msg="The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar."
level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package rootmulti: could not load export data: no export data for "github.com/crypto-org-chain/cronos/store/rootmulti""
level=error msg="Running error: can't run linter goanalysis_metalinter\nbuildir: failed to load package rootmulti: could not load export data: no export data for "github.com/crypto-org-chain/cronos/store/rootmulti""

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6fddcb8 and c028c53.

⛔ Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

📒 Files selected for processing (2)

• CHANGELOG.md (1 hunks)
• go.mod (1 hunks)

🔇 Additional comments (2)

go.mod (1)

254-256: Review core dependency replacements

The replacements for core Cosmos SDK components are pointing to specific commits in the crypto-org-chain forks. This is important for maintaining stability and consistency.

Let's verify the dependency versions are consistent:

CHANGELOG.md (1)

5-8: Bug fix properly documented

The changelog entry correctly documents the fix for the nil pointer error when querying blocks before feemarket module activation. This aligns with the PR objectives.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.46%. Comparing base (a3c2f70) to head (c028c53).
Report is 17 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1714       +/-   ##
===========================================
+ Coverage   16.87%   35.46%   +18.59%     
===========================================
  Files          72      124       +52     
  Lines        6163    11898     +5735     
===========================================
+ Hits         1040     4220     +3180     
- Misses       5000     7254     +2254     
- Partials      123      424      +301     

see 71 files with indirect coverage changes