Problem: v1.4.0 not released #1711
Conversation
yihuang
requested review from
calvinaco and
thomas-nguy
and removed request for
a team
WalkthroughThe pull request updates the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)
3-3: Convert emphasis to proper heading format.The date should use heading syntax instead of emphasis to maintain consistency with markdown standards.
Apply this diff:
-*Dec 2, 2024* +### Dec 2, 2024🧰 Tools
🪛 Markdownlint (0.35.0)
3-3: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
🪛 Markdownlint (0.35.0)
CHANGELOG.md
3-3: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
🔇 Additional comments (1)
CHANGELOG.md (1)
3-10: LGTM! The changelog entry follows the standard format.
The new entry for v1.4.0 is well-structured and provides clear information about the improvements made.
🧰 Tools
🪛 Markdownlint (0.35.0)
3-3: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
CHANGELOG.md (1)
3-12: Verify changelog entries against PR objectives.The changelog entries for v1.4.0 appear consistent with the PR objectives. However, there are a few formatting improvements that could be made:
Consider updating the unordered list style to use asterisks (*) instead of dashes (-) for consistency with the rest of the document:
- - Reproduce iavl prune bug in test - - change iavl dependency back to upstream - - fix prune command with async pruning + * Reproduce iavl prune bug in test + * change iavl dependency back to upstream + * fix prune command with async pruning🧰 Tools
🪛 Markdownlint (0.35.0)
10-10: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
11-11: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
12-12: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
3-3: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
🪛 Markdownlint (0.35.0)
CHANGELOG.md
10-10: Expected: asterisk; Actual: dash
Unordered list style
(MD004, ul-style)
11-11: Expected: asterisk; Actual: dash
Unordered list style
(MD004, ul-style)
12-12: Expected: asterisk; Actual: dash
Unordered list style
(MD004, ul-style)
3-3: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
Changes between rc6 and main branch:
v1.4.0-rc6...main
crypto-org-chain/cosmos-sdk@3300cc8...6031e79
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
Summary by CodeRabbit
Documentation
v1.4.0and previous release candidates, detailing significant bug fixes and improvements.Bug Fixes