Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: no command to fix corrupted data in versiondb (backport: #1685) #1686

Merged

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Nov 11, 2024

Closes: #1683

Solution:

  • add fix command to fix corrupted data in versiondb

rename

support SkipVersionZero

support SkipVersionZero

cleanup

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner November 11, 2024 08:24
@yihuang yihuang requested review from JayT106 and calvinaco and removed request for a team November 11, 2024 08:24
Copy link
Contributor

coderabbitai bot commented Nov 11, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yihuang yihuang requested a review from mmsqe November 11, 2024 08:24
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 50.62500% with 79 lines in your changes missing coverage. Please review.

Project coverage is 36.31%. Comparing base (1f20b38) to head (d406df9).
Report is 1 commits behind head on release/v1.3.x.

Files with missing lines Patch % Lines
versiondb/client/fixdata.go 0.00% 39 Missing ⚠️
versiondb/tsrocksdb/store.go 67.44% 18 Missing and 10 partials ⚠️
versiondb/tsrocksdb/opts.go 0.00% 11 Missing ⚠️
versiondb/client/cmd.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v1.3.x    #1686       +/-   ##
===================================================
+ Coverage           18.81%   36.31%   +17.49%     
===================================================
  Files                  96      146       +50     
  Lines                6966    12623     +5657     
===================================================
+ Hits                 1311     4584     +3273     
- Misses               5513     7585     +2072     
- Partials              142      454      +312     
Files with missing lines Coverage Δ
app/versiondb.go 75.00% <100.00%> (+2.27%) ⬆️
versiondb/tsrocksdb/iterator.go 77.22% <100.00%> (ø)
versiondb/client/cmd.go 0.00% <0.00%> (ø)
versiondb/tsrocksdb/opts.go 76.38% <0.00%> (ø)
versiondb/tsrocksdb/store.go 57.87% <67.44%> (ø)
versiondb/client/fixdata.go 0.00% <0.00%> (ø)

... and 72 files with indirect coverage changes

versiondb/client/fixdata.go Outdated Show resolved Hide resolved
versiondb/client/fixdata.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@yihuang yihuang enabled auto-merge (squash) November 11, 2024 09:49
@yihuang yihuang disabled auto-merge November 11, 2024 10:08
…pto-org-chain#1685)

Closes: crypto-org-chain#1683

Solution:
- add fix command to fix corrupted data in versiondb

rename

support SkipVersionZero

support SkipVersionZero

cleanup

cleanup

cleanup

fix test

cleanup

destroy

log store name

fix data manually

cli

Update versiondb/client/fixdata.go

Signed-off-by: yihuang <[email protected]>

Update versiondb/client/fixdata.go

Signed-off-by: yihuang <[email protected]>

rnemae

Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

fix test

don't return nil as empty slice

add dryrun mode

separete read from iteration

add stores flag

debug

add timestamp api
@yihuang yihuang force-pushed the fix-versiondb-backport branch from 145e2fa to ec7e78e Compare November 12, 2024 05:33
CHANGELOG.md Show resolved Hide resolved
@yihuang yihuang merged commit 93af817 into crypto-org-chain:release/v1.3.x Nov 12, 2024
37 checks passed
@yihuang yihuang deleted the fix-versiondb-backport branch November 12, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants