Problem: no header hash from fallback historicalInfo

[mmsqe]

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

and reduce DefaultHeaderHashNum to 256, for more info

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

• New Features

  • Enhanced compatibility with iavl 1.2.0.
  • Added support for IBC channel upgrade methods.
  • Integrated new EVM transaction format and parallel transaction execution.

• Improvements

  • Adjusted default parallelism settings for the block state machine.
  • Optimized API calls to prevent unnecessary block results.
  • Enhanced upgrade testing with more detailed logging and assertions.

• Bug Fixes

  • Various bug fixes and performance enhancements across transaction handling and encryption modules.

• Documentation

  • Updated CHANGELOG.md to reflect recent changes and improvements.

[coderabbitai]

Walkthrough

The pull request includes significant updates across several files, primarily focusing on the CHANGELOG.md, go.mod, and gomod2nix.toml. The CHANGELOG.md has been revised to document changes across multiple releases, including breaking changes and improvements. The go.mod file reflects updates to module dependencies and versions, including a Go toolchain upgrade. Similarly, the gomod2nix.toml file shows updates to the version and hash for the github.com/evmos/ethermint module. These changes collectively enhance compatibility and functionality within the project.

Changes

File	Change Summary
CHANGELOG.md	Updated to reflect changes for multiple releases, including breaking changes, improvements, and bug fixes. Method signatures updated for compatibility.
go.mod	Updated Go toolchain from go1.22.2 to go1.22.3. Various dependency versions updated, including github.com/evmos/ethermint. Replacements for certain dependencies added.
gomod2nix.toml	Updated version and hash for github.com/evmos/ethermint. No additions or deletions of modules.
integration_tests/test_upgrade.py	Enhanced upgrade testing with new assertions and detailed logging for the upgrade process.

Possibly related PRs

• Problem: sdk v0.50.x is outdated #1464: This PR updates the cosmos-sdk to version v0.50.7, which is related to the main PR's update of the cosmos-sdk to version 0.50.10.
• Problem: recent rpc fixes are not included #1569: This PR includes updates to the go.mod file for the github.com/crypto-org-chain/ethermint dependency, which is also updated in the main PR.
• Problem: get unnecessary block result when only need header #1600: This PR addresses the issue of unnecessary block results in header-related API calls, which is a change noted in the main PR.
• Problem: ibc channel upgrade related methods are not supported #1612: This PR adds support for IBC channel upgrade methods, which aligns with the main PR's addition of similar support.
• Problem: app hash mismatch occurs when upgrade to iavl v1.2.0 #1618: This PR modifies the initial version logic of memiavl for compatibility with iavl version 1.2.0, which is mentioned in the main PR.
• Problem: fix of broken opBlockhash and tx validation are not included #1621: This PR addresses issues with opBlockhash and transaction validation, which are relevant to the changes in the main PR regarding transaction handling and validation improvements.

Suggested reviewers

• calvinaco
• yihuang
• thomas-nguy

🐇 In the changelog, we hop and play,
Reflecting changes, day by day.
Dependencies shift, versions align,
With Ethermint's updates, all is fine.
Bugs are squashed, improvements made,
In this code garden, progress is laid! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.31%. Comparing base (4dda39e) to head (c231c41).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1630       +/-   ##
===========================================
+ Coverage   17.87%   36.31%   +18.43%     
===========================================
  Files          72      123       +51     
  Lines        5168     9715     +4547     
===========================================
+ Hits          924     3528     +2604     
- Misses       4121     5773     +1652     
- Partials      123      414      +291     

see 69 files with indirect coverage changes

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

integration_tests/test_upgrade.py (1)

289-289: LGTM: Assertion for header_hash_num added.

The new assertion correctly checks that the header_hash_num parameter is set to "256" after the upgrade, which aligns with the PR objective of reducing DefaultHeaderHashNum to 256.

Consider adding a brief comment explaining the significance of this value change for better code documentation:

# Verify that DefaultHeaderHashNum has been reduced to 256 as per the upgrade
assert cli.query_params("evm")["header_hash_num"] == "256", p

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between eebed6b and c231c41.

📒 Files selected for processing (1)

• integration_tests/test_upgrade.py (1 hunks)

🧰 Additional context used

🔇 Additional comments (1)

integration_tests/test_upgrade.py (1)

290-291: ⚠️ Potential issue

Please clarify the removal of the icaauth parameter.

The test now expects an AssertionError when querying the icaauth parameter. This is a significant change in behavior that wasn't explicitly mentioned in the PR objectives or summary.

Could you please provide more context on why this parameter has been removed and what implications this has for the system? Additionally, consider adding a comment in the code explaining this change.

To verify the removal of the icaauth parameter across the codebase, please run the following script:

This will help us understand if the removal of the icaauth parameter is consistent across the codebase and if there are any remaining references that need to be addressed.