Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: e2ee module not up to date #1610

Merged
merged 17 commits into from
Sep 27, 2024

no panic

44a0072
Select commit
Loading
Failed to load commit list.
Merged

Problem: e2ee module not up to date #1610

no panic
44a0072
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 27, 2024 in 0s

36.97% (+0.84%) compared to bbdd407

View this Pull Request on Codecov

36.97% (+0.84%) compared to bbdd407

Details

Codecov Report

Attention: Patch coverage is 54.01929% with 143 lines in your changes missing coverage. Please review.

Project coverage is 36.97%. Comparing base (bbdd407) to head (44a0072).

Files with missing lines Patch % Lines
app/proposal.go 22.66% 57 Missing and 1 partial ⚠️
x/e2ee/client/cli/encrypt_to_validators.go 59.37% 13 Missing and 13 partials ⚠️
x/cronos/types/messages.go 46.15% 13 Missing and 1 partial ⚠️
x/e2ee/client/cli/pubkey.go 60.00% 5 Missing and 5 partials ⚠️
x/e2ee/client/cli/query.go 82.22% 4 Missing and 4 partials ⚠️
x/cronos/keeper/msg_server.go 0.00% 7 Missing ⚠️
x/cronos/client/cli/tx.go 73.91% 3 Missing and 3 partials ⚠️
x/cronos/keeper/grpc_query.go 0.00% 6 Missing ⚠️
x/e2ee/types/msg.go 0.00% 5 Missing ⚠️
x/e2ee/client/cli/tx.go 92.30% 1 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1610      +/-   ##
==========================================
+ Coverage   36.12%   36.97%   +0.84%     
==========================================
  Files          97      102       +5     
  Lines        7725     8035     +310     
==========================================
+ Hits         2791     2971     +180     
- Misses       4585     4686     +101     
- Partials      349      378      +29     
Files with missing lines Coverage Δ
x/cronos/keeper/keeper.go 63.52% <100.00%> (+0.46%) ⬆️
x/cronos/types/keys.go 0.00% <ø> (ø)
x/e2ee/client/cli/cmd.go 100.00% <100.00%> (ø)
x/e2ee/module.go 65.95% <100.00%> (+3.16%) ⬆️
app/block_address.go 23.07% <0.00%> (ø)
x/e2ee/client/cli/tx.go 92.30% <92.30%> (ø)
x/e2ee/types/msg.go 41.66% <0.00%> (-1.20%) ⬇️
x/cronos/client/cli/tx.go 42.85% <73.91%> (+3.21%) ⬆️
x/cronos/keeper/grpc_query.go 0.00% <0.00%> (ø)
x/cronos/keeper/msg_server.go 14.28% <0.00%> (-1.79%) ⬇️
... and 5 more

... and 1 file with indirect coverage changes