Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: disable of create vesting account messages are not complete #1541

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Aug 7, 2024

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • New Features

    • Introduced changes to account management, disabling specific message types for enhanced control and security in transaction processing.
  • Bug Fixes

    • Updated dependencies to more stable release versions, potentially improving reliability and performance across the application.

@mmsqe mmsqe requested a review from a team as a code owner August 7, 2024 03:11
@mmsqe mmsqe requested review from yihuang and JayT106 and removed request for a team August 7, 2024 03:11
Copy link
Contributor

coderabbitai bot commented Aug 7, 2024

Walkthrough

This update introduces significant changes to the account management process within the IBC framework by disabling two message types, MsgCreatePermanentLockedAccount and MsgCreatePeriodicVestingAccount. Additionally, it optimizes dependency management by shifting to stable versions of the github.com/cometbft/cometbft and github.com/evmos/ethermint modules, enhancing reliability and maintainability. These changes reflect a commitment to simplifying functionality and improving overall application robustness.

Changes

Files Change Summary
CHANGELOG.md Disabled message types MsgCreatePermanentLockedAccount and MsgCreatePeriodicVestingAccount, impacting account management functionality.
app/app.go Added MsgCreatePermanentLockedAccount and MsgCreatePeriodicVestingAccount to DisabledAuthzMsgs, refining transaction control for vesting accounts.
go.mod, gomod2nix.toml Updated dependency versions: simplified github.com/cometbft/cometbft to stable version v0.38.10 and updated github.com/evmos/ethermint to newer commit.

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant User
    participant IBC

    User->>App: Create Account Request
    alt Account Type Disabled
        App->>User: Error: Account creation type disabled
    else Valid Account Type
        App->>IBC: Send Create Account Transaction
        IBC->>App: Confirm Account Creation
        App->>User: Account Created Successfully
    end
Loading

🐰 In the meadow bright and fair,
New changes dance upon the air.
Locked accounts now take their rest,
While stable paths we deem the best.
With every hop, we streamline flow,
To make our world a better show! 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mmsqe mmsqe enabled auto-merge August 7, 2024 03:17
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.12%. Comparing base (bb51671) to head (9cfb95a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1541   +/-   ##
=======================================
  Coverage   36.12%   36.12%           
=======================================
  Files          97       97           
  Lines        7725     7725           
=======================================
  Hits         2791     2791           
  Misses       4585     4585           
  Partials      349      349           

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bb51671 and 9cfb95a.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (4)
  • CHANGELOG.md (1 hunks)
  • app/app.go (1 hunks)
  • go.mod (2 hunks)
  • gomod2nix.toml (2 hunks)
Files skipped from review due to trivial changes (2)
  • go.mod
  • gomod2nix.toml
Additional comments not posted (2)
CHANGELOG.md (1)

13-13: Changelog entry looks good.

The entry is clear and correctly formatted, accurately reflecting the changes made.

app/app.go (1)

1043-1044: Update to DisabledAuthzMsgs looks good.

The addition of MsgCreatePermanentLockedAccount and MsgCreatePeriodicVestingAccount to the DisabledAuthzMsgs slice is correctly implemented.

@mmsqe mmsqe added this pull request to the merge queue Aug 7, 2024
Merged via the queue into crypto-org-chain:main with commit 5310e86 Aug 7, 2024
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants