Problem: redundant copy in check validate #1498
Conversation
WalkthroughThe latest updates focus on enhancing the efficiency of key comparisons within the Changes
Poem
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1498 +/- ##
===========================================
+ Coverage 17.54% 35.87% +18.33%
===========================================
Files 87 136 +49
Lines 5273 9809 +4536
===========================================
+ Hits 925 3519 +2594
- Misses 4238 5894 +1656
- Partials 110 396 +286
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- versiondb/tsrocksdb/iterator.go (3 hunks)
Additional context used
GitHub Check: codecov/patch
versiondb/tsrocksdb/iterator.go
[warning] 152-152: versiondb/tsrocksdb/iterator.go#L152
Added line #L152 was not covered by tests
LanguageTool
CHANGELOG.md
[grammar] ~21-~21: The conjunction “when” requires the past participle “registered”. Or did you mean “you register”?
Context: ...ronos/pull/1421) Validate e2ee key when register. * (store) [#1448](https://github.com/c...(IF_VB_PCT)
[misspelling] ~132-~132: Did you mean “or”? ‘Of’ refers to parts of a whole, while ‘or’ refers to alternatives.
Context: ...onos/pull/1216) Update ethermint to fix of avoid redundant parse chainID from gens...(CONFUSION_OF_OR)
[style] ~173-~173: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...n processing and double spend check. - [cronos#742](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~174-~174: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e handler for v0.8.0-gravity-alpha2. - [cronos#750](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~175-~175: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e handler for v0.8.0-gravity-alpha3. - [cronos#769](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~176-~176: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...cope of the contract that manage it. - [cronos#775](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~177-~177: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...775) Support turnbridge transaction. - [cronos#781](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~178-~178: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: .../cronos/pull/781) Add prune command. - [cronos#830](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~181-~181: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...upgrade handler for v2.0.0-testnet3. - [cronos#795](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~182-~182: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: .../795) Support permissions in cronos. - [cronos#997](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~183-~183: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ontract for cronos originated crc20. - [cronos#1005](https://github.com/crypto-org-cha...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~184-~184: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...o-ibc event in case of source token. - [cronos#1069](https://github.com/crypto-org-cha...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~185-~185: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ov1.10.26and ibc-go tov6.2.0. - [cronos#1147](https://github.com/crypto-org-cha...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~189-~189: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...adjusted correctly in ibc-go v7.2.0. - [cronos#1163](https://github.com/crypto-org-cha...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~190-~190: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ateful precompiled contract for ica. - [cronos#837](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~191-~191: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...teful precompiled contract for bank. - [cronos#1184](https://github.com/crypto-org-cha...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~192-~192: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ull/1184) Update ibc-go tov7.3.1. - [cronos#1186](https://github.com/crypto-org-cha...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~193-~193: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... max block gas limit in new version. - [cronos#1187](https://github.com/crypto-org-cha...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~194-~194: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...1187) Disable gravity module in app. - [cronos#1185](https://github.com/crypto-org-cha...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~195-~195: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nos/pull/1185) Support ibc callback. - [cronos#1196](https://github.com/crypto-org-cha...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[grammar] ~214-~214: It seems that “to” is missing before the verb.
Context: .../cronos/pull/1150) Fix memiavl's unsafe retain of the root hashes. ### Features - [#...(MISSING_TO_BETWEEN_BE_AND_VB)
[misspelling] ~218-~218: Did you mean the phrasal verb “clean up” instead of the noun ‘cleanup’?
Context: .../pull/1042) call Close method on app to cleanup resource on graceful shutdown ([ethermi...(CLEAN_UP)
[grammar] ~334-~334: After ‘it’, use the third-person verb form “fixes”.
Context: ...790) Update cosmos-sdk tov0.46.7, it fix a migration issue which affects pending...(IT_VBZ)
[style] ~401-~401: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...file state streamer (backport #702). - [cronos#730](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~423-~423: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...elSendToChain support from evm call. - [cronos#600](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~424-~424: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...plement bidirectional token mapping. - [cronos#611](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~425-~425: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...owledgement error in ibc middleware. - [cronos#627](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~440-~440: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...leware, use ibc-go upstream version. - [cronos#550](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~441-~441: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...basic json-rpc apis on pruned nodes. - [cronos#549](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~442-~442: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom tx indexer feature of ethermint. - [cronos#673](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~460-~460: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ed in json-rpc apis (backport #502). - [cronos#526](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~461-~461: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... Fix tendermint duplicated tx issue. - [cronos#584](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~462-~462: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...shes returned in some JSON-RPC apis. - [cronos#587](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~463-~463: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... tx patch cmd recompute eth tx hash. - [cronos#595](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~469-~469: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nd to patch txs post v0.7.0 upgrade. - [cronos#522](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~470-~470: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... the tendermint tx duplicated issue. - [cronos#585](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~484-~484: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ase fee related logic in the code. - [ethermint#817](https://github.com/tharsis/ethermi...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~485-~485: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ogic related to effectiveGasPrice. - [ethermint#822](https://github.com/tharsis/ethermi...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~488-~488: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... tx when block gas limit exceeded. - [cosmos-sdk#10725](https://github.com/cosmos/cosmos...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~496-~496: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e url query parameter in swagger-ui. - [cronos#328](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~497-~497: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...query result when--traceenabled. - [cronos#441](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~504-~504: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...ll/329) Fix panic of eth_call on blocks prior to upgrade. - [cronos#340](https://github....(EN_WORDINESS_PREMIUM_PRIOR_TO)
[style] ~505-~505: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...eth_call on blocks prior to upgrade. - [cronos#340](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~506-~506: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...t, b) fix data racestraceContext. - [cronos#370](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~507-~507: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...g, add websockets integration tests. - [cronos#378](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~508-~508: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... add returnValue message on tracing. - [cronos#446](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[grammar] ~628-~628: After ‘it’, use the third-person verb form “upgrades”.
Context: ...org Chain. In addition to that, it also upgrade ethermint to its latest version (v0.5.0...(IT_VBZ)
Markdownlint
CHANGELOG.md
56-56: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
68-68: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
76-76: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
84-84: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
92-92: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
93-93: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
94-94: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
98-98: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
106-106: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
107-107: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
108-108: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
109-109: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
110-110: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
111-111: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
115-115: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
116-116: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
122-122: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
123-123: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
124-124: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
125-125: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
126-126: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
130-130: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
131-131: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
132-132: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
133-133: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
134-134: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
135-135: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
139-139: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
140-140: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
141-141: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
142-142: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
143-143: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
144-144: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
148-148: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
149-149: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
150-150: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
158-158: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
159-159: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
163-163: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
171-171: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
172-172: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
173-173: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
174-174: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
175-175: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
176-176: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
177-177: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
178-178: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
179-179: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
180-180: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
181-181: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
182-182: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
183-183: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
184-184: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
185-185: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
186-186: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
187-187: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
188-188: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
189-189: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
190-190: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
191-191: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
192-192: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
193-193: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
194-194: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
195-195: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
199-199: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
200-200: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
201-201: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
202-202: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
203-203: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
204-204: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
205-205: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
206-206: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
207-207: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
208-208: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
209-209: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
210-210: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
211-211: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
212-212: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
213-213: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
214-214: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
218-218: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
219-219: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
220-220: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
221-221: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
222-222: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
223-223: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
224-224: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
225-225: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
229-229: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
230-230: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
231-231: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
232-232: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
233-233: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
234-234: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
235-235: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
236-236: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
237-237: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
238-238: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
239-239: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
240-240: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
241-241: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
242-242: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
243-243: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
244-244: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
245-245: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
246-246: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
247-247: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
248-248: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
249-249: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
250-250: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
251-251: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
252-252: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
253-253: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
261-261: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
262-262: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
263-263: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
267-267: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
268-268: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
269-269: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
270-270: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
271-271: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
272-272: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
273-273: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
281-281: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
289-289: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
293-293: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
294-294: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
295-295: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
303-303: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
307-307: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
308-308: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
309-309: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
317-317: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
325-325: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
333-333: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
334-334: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
343-343: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
351-351: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
359-359: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
367-367: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
368-368: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
369-369: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
370-370: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
378-378: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
386-386: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
387-387: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
395-395: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
399-399: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
400-400: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
401-401: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
409-409: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
421-421: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
422-422: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
423-423: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
424-424: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
425-425: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
426-426: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
427-427: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
431-431: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
432-432: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
433-433: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
437-437: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
438-438: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
439-439: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
440-440: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
441-441: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
442-442: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
450-450: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
458-458: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
459-459: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
460-460: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
461-461: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
462-462: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
463-463: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
467-467: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
468-468: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
469-469: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
470-470: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
478-478: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
479-479: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
480-480: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
481-481: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
482-482: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
483-483: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
484-484: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
485-485: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
486-486: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
487-487: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
488-488: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
489-489: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
493-493: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
494-494: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
495-495: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
496-496: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
497-497: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
501-501: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
502-502: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
503-503: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
504-504: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
505-505: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
506-506: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
507-507: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
508-508: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
516-516: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
517-517: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
525-525: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
533-533: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
534-534: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
535-535: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
539-539: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
540-540: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
548-548: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
549-549: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
550-550: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
551-551: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
552-552: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
560-560: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
564-564: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
565-565: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
566-566: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
567-567: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
577-577: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
581-581: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
582-582: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
583-583: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
584-584: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
588-588: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
589-589: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
600-600: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
601-601: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
602-602: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
603-603: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
604-604: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
608-608: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
609-609: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
610-610: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
620-620: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
621-621: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
632-632: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
636-636: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
637-637: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
638-638: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
639-639: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
640-640: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
641-641: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
643-643: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
644-644: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
652-652: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
656-656: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
660-660: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
670-670: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
671-671: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
672-672: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
673-673: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
679-679: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
680-680: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
684-684: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
42-42: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
50-50: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
62-62: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
70-70: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
78-78: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
86-86: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
100-100: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
118-118: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
152-152: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
165-165: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
255-255: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
275-275: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
283-283: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
297-297: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
311-311: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
319-319: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
327-327: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
337-337: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
345-345: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
353-353: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
361-361: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
372-372: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
380-380: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
389-389: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
403-403: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
411-411: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
415-415: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
444-444: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
452-452: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
472-472: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
510-510: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
519-519: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
527-527: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
542-542: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
554-554: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
569-569: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
591-591: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
612-612: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
623-623: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
646-646: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
662-662: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
Additional comments not posted (4)
versiondb/tsrocksdb/iterator.go (3)
26-26: Verify the correctness ofextractSliceBytesusage.Ensure that using
extractSliceBytesinstead ofmoveSliceToBytesin this context is correct and does not introduce any issues with data handling.
78-78: Verify the correctness ofextractSliceBytesusage.Ensure that using
extractSliceBytesinstead ofmoveSliceToBytesin this context is correct and does not introduce any issues with data handling.
147-155: Ensure proper handling of*Sliceafter callingextractSliceBytes.The cautionary note indicates that the
*Sliceshould not be used after calling this function. Ensure that this is correctly handled in all usages ofextractSliceBytes.Tools
GitHub Check: codecov/patch
[warning] 152-152: versiondb/tsrocksdb/iterator.go#L152
Added line #L152 was not covered by testsCHANGELOG.md (1)
30-30: LGTM!The changelog entry for PR #1498 is correctly added and follows the existing format.
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (2 hunks)
- versiondb/tsrocksdb/iterator.go (4 hunks)
Additional context used
GitHub Check: codecov/patch
versiondb/tsrocksdb/iterator.go
[warning] 156-156: versiondb/tsrocksdb/iterator.go#L156
Added line #L156 was not covered by tests
LanguageTool
CHANGELOG.md
[grammar] ~50-~50: The conjunction “when” requires the past participle “registered”. Or did you mean “you register”?
Context: ...ronos/pull/1421) Validate e2ee key when register. * [#1437](https://github.com/crypto-or...(IF_VB_PCT)
[misspelling] ~175-~175: Did you mean “or”? ‘Of’ refers to parts of a whole, while ‘or’ refers to alternatives.
Context: ...onos/pull/1216) Update ethermint to fix of avoid redundant parse chainID from gens...(CONFUSION_OF_OR)
[style] ~216-~216: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...n processing and double spend check. - [cronos#742](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~217-~217: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e handler for v0.8.0-gravity-alpha2. - [cronos#750](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~218-~218: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e handler for v0.8.0-gravity-alpha3. - [cronos#769](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~219-~219: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...cope of the contract that manage it. - [cronos#775](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~220-~220: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...775) Support turnbridge transaction. - [cronos#781](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~221-~221: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: .../cronos/pull/781) Add prune command. - [cronos#830](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~224-~224: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...upgrade handler for v2.0.0-testnet3. - [cronos#795](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~225-~225: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: .../795) Support permissions in cronos. - [cronos#997](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~226-~226: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ontract for cronos originated crc20. - [cronos#1005](https://github.com/crypto-org-cha...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~227-~227: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...o-ibc event in case of source token. - [cronos#1069](https://github.com/crypto-org-cha...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~228-~228: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ov1.10.26and ibc-go tov6.2.0. - [cronos#1147](https://github.com/crypto-org-cha...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~232-~232: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...adjusted correctly in ibc-go v7.2.0. - [cronos#1163](https://github.com/crypto-org-cha...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~233-~233: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ateful precompiled contract for ica. - [cronos#837](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~234-~234: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...teful precompiled contract for bank. - [cronos#1184](https://github.com/crypto-org-cha...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~235-~235: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ull/1184) Update ibc-go tov7.3.1. - [cronos#1186](https://github.com/crypto-org-cha...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~236-~236: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... max block gas limit in new version. - [cronos#1187](https://github.com/crypto-org-cha...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~237-~237: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...1187) Disable gravity module in app. - [cronos#1185](https://github.com/crypto-org-cha...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~238-~238: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nos/pull/1185) Support ibc callback. - [cronos#1196](https://github.com/crypto-org-cha...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[grammar] ~257-~257: It seems that “to” is missing before the verb.
Context: .../cronos/pull/1150) Fix memiavl's unsafe retain of the root hashes. ### Features - [#...(MISSING_TO_BETWEEN_BE_AND_VB)
[misspelling] ~261-~261: Did you mean the phrasal verb “clean up” instead of the noun ‘cleanup’?
Context: .../pull/1042) call Close method on app to cleanup resource on graceful shutdown ([ethermi...(CLEAN_UP)
[grammar] ~377-~377: After ‘it’, use the third-person verb form “fixes”.
Context: ...790) Update cosmos-sdk tov0.46.7, it fix a migration issue which affects pending...(IT_VBZ)
[style] ~444-~444: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...file state streamer (backport #702). - [cronos#730](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~466-~466: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...elSendToChain support from evm call. - [cronos#600](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~467-~467: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...plement bidirectional token mapping. - [cronos#611](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~468-~468: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...owledgement error in ibc middleware. - [cronos#627](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~483-~483: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...leware, use ibc-go upstream version. - [cronos#550](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~484-~484: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...basic json-rpc apis on pruned nodes. - [cronos#549](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~485-~485: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom tx indexer feature of ethermint. - [cronos#673](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~503-~503: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ed in json-rpc apis (backport #502). - [cronos#526](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~504-~504: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... Fix tendermint duplicated tx issue. - [cronos#584](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~505-~505: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...shes returned in some JSON-RPC apis. - [cronos#587](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~506-~506: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... tx patch cmd recompute eth tx hash. - [cronos#595](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~512-~512: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nd to patch txs post v0.7.0 upgrade. - [cronos#522](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~513-~513: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... the tendermint tx duplicated issue. - [cronos#585](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~527-~527: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ase fee related logic in the code. - [ethermint#817](https://github.com/tharsis/ethermi...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~528-~528: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ogic related to effectiveGasPrice. - [ethermint#822](https://github.com/tharsis/ethermi...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~531-~531: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... tx when block gas limit exceeded. - [cosmos-sdk#10725](https://github.com/cosmos/cosmos...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~539-~539: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e url query parameter in swagger-ui. - [cronos#328](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~540-~540: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...query result when--traceenabled. - [cronos#441](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~547-~547: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...ll/329) Fix panic of eth_call on blocks prior to upgrade. - [cronos#340](https://github....(EN_WORDINESS_PREMIUM_PRIOR_TO)
[style] ~548-~548: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...eth_call on blocks prior to upgrade. - [cronos#340](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~549-~549: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...t, b) fix data racestraceContext. - [cronos#370](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~550-~550: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...g, add websockets integration tests. - [cronos#378](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[style] ~551-~551: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... add returnValue message on tracing. - [cronos#446](https://github.com/crypto-org-chai...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
[grammar] ~671-~671: After ‘it’, use the third-person verb form “upgrades”.
Context: ...org Chain. In addition to that, it also upgrade ethermint to its latest version (v0.5.0...(IT_VBZ)
[uncategorized] ~709-~709: Possible missing comma found.
Context: ... version is a new scaffolding of cronos project where ethermint is included as a librar...(AI_HYDRA_LEO_MISSING_COMMA)
Markdownlint
CHANGELOG.md
99-99: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
111-111: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
119-119: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
127-127: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
135-135: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
136-136: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
137-137: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
141-141: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
149-149: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
150-150: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
151-151: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
152-152: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
153-153: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
154-154: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
158-158: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
159-159: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
165-165: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
166-166: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
167-167: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
168-168: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
169-169: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
173-173: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
174-174: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
175-175: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
176-176: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
177-177: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
178-178: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
182-182: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
183-183: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
184-184: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
185-185: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
186-186: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
187-187: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
191-191: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
192-192: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
193-193: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
201-201: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
202-202: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
206-206: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
214-214: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
215-215: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
216-216: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
217-217: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
218-218: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
219-219: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
220-220: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
221-221: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
222-222: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
223-223: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
224-224: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
225-225: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
226-226: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
227-227: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
228-228: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
229-229: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
230-230: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
231-231: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
232-232: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
233-233: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
234-234: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
235-235: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
236-236: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
237-237: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
238-238: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
242-242: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
243-243: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
244-244: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
245-245: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
246-246: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
247-247: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
248-248: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
249-249: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
250-250: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
251-251: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
252-252: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
253-253: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
254-254: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
255-255: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
256-256: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
257-257: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
261-261: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
262-262: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
263-263: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
264-264: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
265-265: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
266-266: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
267-267: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
268-268: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
272-272: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
273-273: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
274-274: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
275-275: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
276-276: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
277-277: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
278-278: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
279-279: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
280-280: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
281-281: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
282-282: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
283-283: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
284-284: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
285-285: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
286-286: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
287-287: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
288-288: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
289-289: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
290-290: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
291-291: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
292-292: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
293-293: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
294-294: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
295-295: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
296-296: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
304-304: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
305-305: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
306-306: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
310-310: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
311-311: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
312-312: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
313-313: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
314-314: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
315-315: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
316-316: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
324-324: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
332-332: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
336-336: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
337-337: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
338-338: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
346-346: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
350-350: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
351-351: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
352-352: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
360-360: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
368-368: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
376-376: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
377-377: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
386-386: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
394-394: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
402-402: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
410-410: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
411-411: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
412-412: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
413-413: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
421-421: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
429-429: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
430-430: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
438-438: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
442-442: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
443-443: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
444-444: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
452-452: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
464-464: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
465-465: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
466-466: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
467-467: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
468-468: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
469-469: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
470-470: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
474-474: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
475-475: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
476-476: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
480-480: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
481-481: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
482-482: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
483-483: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
484-484: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
485-485: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
493-493: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
501-501: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
502-502: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
503-503: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
504-504: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
505-505: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
506-506: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
510-510: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
511-511: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
512-512: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
513-513: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
521-521: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
522-522: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
523-523: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
524-524: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
525-525: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
526-526: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
527-527: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
528-528: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
529-529: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
530-530: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
531-531: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
532-532: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
536-536: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
537-537: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
538-538: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
539-539: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
540-540: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
544-544: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
545-545: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
546-546: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
547-547: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
548-548: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
549-549: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
550-550: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
551-551: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
559-559: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
560-560: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
568-568: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
576-576: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
577-577: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
578-578: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
582-582: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
583-583: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
591-591: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
592-592: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
593-593: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
594-594: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
595-595: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
603-603: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
607-607: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
608-608: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
609-609: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
610-610: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
620-620: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
624-624: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
625-625: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
626-626: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
627-627: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
631-631: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
632-632: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
643-643: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
644-644: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
645-645: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
646-646: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
647-647: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
651-651: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
652-652: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
653-653: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
663-663: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
664-664: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
675-675: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
679-679: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
680-680: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
681-681: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
682-682: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
683-683: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
684-684: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
686-686: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
687-687: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
695-695: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
699-699: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
703-703: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
713-713: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
714-714: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
715-715: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
716-716: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
722-722: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
723-723: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
727-727: Expected: asterisk; Actual: dash
Unordered list style(MD004, ul-style)
25-25: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
86-86: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
87-87: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
26-26: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
38-38: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
58-58: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
66-66: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
84-84: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
93-93: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
105-105: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
113-113: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
121-121: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
129-129: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
143-143: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
161-161: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
195-195: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
208-208: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
298-298: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
318-318: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
326-326: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
340-340: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
354-354: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
362-362: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
370-370: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
380-380: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
388-388: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
396-396: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
404-404: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
415-415: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
423-423: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
432-432: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
446-446: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
454-454: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
458-458: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
487-487: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
495-495: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
515-515: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
553-553: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
562-562: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
570-570: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
585-585: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
597-597: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
612-612: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
634-634: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
655-655: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
666-666: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
689-689: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
705-705: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
Additional comments not posted (3)
versiondb/tsrocksdb/iterator.go (2)
26-30: Ensure correct usage ofextractSliceBytes.The change from
moveSliceToBytestoextractSliceBytesaims to improve performance by avoiding unnecessary data copying. Ensure thatextractSliceBytesis used correctly and that thekeyis not used after being freed.Verification successful
Ensure correct usage of
extractSliceBytes.The change from
moveSliceToBytestoextractSliceBytesaims to improve performance by avoiding unnecessary data copying. Thekeyis not used after being freed in both instances whereextractSliceBytesis called.
- In the first instance,
key.Free()is called immediately after extracting the bytes and before any further use ofkey.- In the second instance,
srcKey.Free()is deferred, ensuring that the key is freed at the end of the function, and there are no further uses ofkeyafter extracting the bytes.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `extractSliceBytes` match the correct usage. # Test: Search for the function usage. Expect: Correct usage of `extractSliceBytes`. rg --type go $'extractSliceBytes'Length of output: 375
Script:
#!/bin/bash # Description: Display all instances of `extractSliceBytes` usage in `iterator.go` for detailed inspection. # Extract and display lines around `extractSliceBytes` function calls in `iterator.go` rg --context 5 --type go extractSliceBytes versiondb/tsrocksdb/iterator.goLength of output: 1008
81-83: Ensure correct usage ofextractSliceBytes.The change from
moveSliceToBytestoextractSliceBytesaims to improve performance by avoiding unnecessary data copying. Ensure thatextractSliceBytesis used correctly and that thesrcKeyis not used after being freed.Verification successful
Ensure correct usage of
extractSliceBytes.The change from
moveSliceToBytestoextractSliceBytesis correctly implemented. In both instances whereextractSliceBytesis used, the slice is freed immediately after extracting the byte data, ensuring that it is not used afterward.
Validfunction (lines 81-83)newRocksDBIteratorfunctionScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `extractSliceBytes` match the correct usage. # Test: Search for the function usage. Expect: Correct usage of `extractSliceBytes`. rg --type go $'extractSliceBytes'Length of output: 375
Script:
#!/bin/bash # Description: Retrieve the definition and usages of the function `extractSliceBytes` for further analysis. # Get the definition of the function `extractSliceBytes` ast-grep --lang go --pattern $'func extractSliceBytes(s *grocksdb.Slice) []byte { $$$ }' versiondb/tsrocksdb/iterator.go # Get the usage of the function `extractSliceBytes` within the file rg --type go 'extractSliceBytes' versiondb/tsrocksdb/iterator.goLength of output: 723
Script:
#!/bin/bash # Description: Retrieve the `Valid` function and the context of the other usage of `extractSliceBytes` for further analysis. # Get the `Valid` function from `iterator.go` ast-grep --lang go --pattern $'func (itr *Iterator) Valid() bool { $$$ }' versiondb/tsrocksdb/iterator.go # Get the context of the other usage of `extractSliceBytes` rg --context 10 --type go 'extractSliceBytes' versiondb/tsrocksdb/iterator.goLength of output: 1674
CHANGELOG.md (1)
22-24: Correct the style of unordered list items.The current style uses dashes for list items. According to Markdownlint, asterisks are expected.
- * (versiondb) [#1491](https://github.com/crypto-org-chain/cronos/pull/1491) Free slice data in HasAtVersion. - * (versiondb) [#1498](https://github.com/crypto-org-chain/cronos/pull/1498) Check validity with extractSliceBytes to avoid copying slice data. + * (versiondb) [#1491](https://github.com/crypto-org-chain/cronos/pull/1491) Free slice data in HasAtVersion. + * (versiondb) [#1498](https://github.com/crypto-org-chain/cronos/pull/1498) Check validity with extractSliceBytes to avoid copying slice data.Likely invalid or redundant comment.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- versiondb/tsrocksdb/iterator.go (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- versiondb/tsrocksdb/iterator.go
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (2 hunks)
Additional context used
LanguageTool
CHANGELOG.md
[grammar] ~50-~50: The conjunction “when” requires the past participle “registered”. Or did you mean “you register”?
Context: ...ronos/pull/1421) Validate e2ee key when register. * [#1437](https://github.com/crypto-or...(IF_VB_PCT)
Markdownlint
CHANGELOG.md
25-25: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
26-26: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
38-38: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
58-58: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
66-66: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
86-86: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
87-87: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
84-84: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
Additional comments not posted (3)
CHANGELOG.md (3)
22-22: LGTM!The changelog entry for PR #1491 is correctly formatted and clear.
23-23: LGTM!The changelog entry for PR #1498 is correctly formatted and clear.
26-26: LGTM!The date entry is correctly formatted.
Tools
Markdownlint
26-26: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
Bug Fixes
Documentation