Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: optimistic execution is not enabled by default #1488

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jun 26, 2024

Solution:

  • enable it

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • New Features
    • Introduced optimistic execution functionality to enhance application performance.

@yihuang yihuang requested a review from a team as a code owner June 26, 2024 12:14
@yihuang yihuang requested review from mmsqe and leejw51crypto and removed request for a team June 26, 2024 12:14
Copy link
Contributor

coderabbitai bot commented Jun 26, 2024

Walkthrough

The recent update to the crypto-org-chain/cronos repository introduces a feature allowing optimistic execution. This entails appending a new setting for optimistic execution to the baseAppOptions in the app/app.go file during initialization, enhancing the application performance.

Changes

Files Change Summaries
CHANGELOG.md Added summary for the new feature enabling optimistic execution as part of PR #1488.
app/app.go Appended a setting for optimistic execution to baseAppOptions during app initialization.

Poem

In the code forests yonder, lines replete,
A sparkle of optimism—a feat so neat!
Execution swift, like a rabbit's fleet hop,
Improvements in flow, they just won’t stop.
With settings now enhanced, our code’s elite!
To infinity, we tweak, without a code drop.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.36%. Comparing base (1cc2d06) to head (f151a55).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1488      +/-   ##
==========================================
- Coverage   35.85%   35.36%   -0.49%     
==========================================
  Files         136      136              
  Lines        9806     9806              
==========================================
- Hits         3516     3468      -48     
- Misses       5894     5949      +55     
+ Partials      396      389       -7     

see 5 files with indirect coverage changes

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <[email protected]>
@yihuang yihuang enabled auto-merge June 26, 2024 12:28
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1cc2d06 and f151a55.

Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • app/app.go (1 hunks)
Additional context used
LanguageTool
CHANGELOG.md

[grammar] ~21-~21: The conjunction “when” requires the past participle “registered”. Or did you mean “you register”? (IF_VB_PCT)
Context: ...ronos/pull/1421) Validate e2ee key when register. * (store) [#1448](https://github.com/c...


[style] ~26-~26: The double modal “wanted returned” is nonstandard (only accepted in certain dialects). Consider “to be returned”. (NEEDS_FIXED)
Context: ...in/cronos/pull/1484) Respect gas wanted returned by ante handler. * [#1488](https://gith...


[misspelling] ~129-~129: Did you mean “or”? ‘Of’ refers to parts of a whole, while ‘or’ refers to alternatives. (CONFUSION_OF_OR)
Context: ...onos/pull/1216) Update ethermint to fix of avoid redundant parse chainID from gens...


[style] ~170-~170: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...n processing and double spend check. - [cronos#742](https://github.com/crypto-org-chai...


[style] ~171-~171: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...e handler for v0.8.0-gravity-alpha2. - [cronos#750](https://github.com/crypto-org-chai...


[style] ~172-~172: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...e handler for v0.8.0-gravity-alpha3. - [cronos#769](https://github.com/crypto-org-chai...


[style] ~173-~173: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...cope of the contract that manage it. - [cronos#775](https://github.com/crypto-org-chai...


[style] ~174-~174: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...775) Support turnbridge transaction. - [cronos#781](https://github.com/crypto-org-chai...


[style] ~175-~175: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: .../cronos/pull/781) Add prune command. - [cronos#830](https://github.com/crypto-org-chai...


[style] ~178-~178: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...upgrade handler for v2.0.0-testnet3. - [cronos#795](https://github.com/crypto-org-chai...


[style] ~179-~179: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: .../795) Support permissions in cronos. - [cronos#997](https://github.com/crypto-org-chai...


[style] ~180-~180: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ontract for cronos originated crc20. - [cronos#1005](https://github.com/crypto-org-cha...


[style] ~181-~181: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...o-ibc event in case of source token. - [cronos#1069](https://github.com/crypto-org-cha...


[style] ~182-~182: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...o v1.10.26 and ibc-go to v6.2.0. - [cronos#1147](https://github.com/crypto-org-cha...


[style] ~186-~186: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...adjusted correctly in ibc-go v7.2.0. - [cronos#1163](https://github.com/crypto-org-cha...


[style] ~187-~187: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ateful precompiled contract for ica. - [cronos#837](https://github.com/crypto-org-chai...


[style] ~188-~188: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...teful precompiled contract for bank. - [cronos#1184](https://github.com/crypto-org-cha...


[style] ~189-~189: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ull/1184) Update ibc-go to v7.3.1. - [cronos#1186](https://github.com/crypto-org-cha...


[style] ~190-~190: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... max block gas limit in new version. - [cronos#1187](https://github.com/crypto-org-cha...


[style] ~191-~191: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...1187) Disable gravity module in app. - [cronos#1185](https://github.com/crypto-org-cha...


[style] ~192-~192: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...nos/pull/1185) Support ibc callback. - [cronos#1196](https://github.com/crypto-org-cha...


[grammar] ~211-~211: It seems that “to” is missing before the verb. (MISSING_TO_BETWEEN_BE_AND_VB)
Context: .../cronos/pull/1150) Fix memiavl's unsafe retain of the root hashes. ### Features - [#...


[misspelling] ~215-~215: Did you mean the phrasal verb “clean up” instead of the noun ‘cleanup’? (CLEAN_UP)
Context: .../pull/1042) call Close method on app to cleanup resource on graceful shutdown ([ethermi...


[grammar] ~331-~331: After ‘it’, use the third-person verb form “fixes”. (IT_VBZ)
Context: ...790) Update cosmos-sdk to v0.46.7, it fix a migration issue which affects pending...


[style] ~398-~398: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...file state streamer (backport #702). - [cronos#730](https://github.com/crypto-org-chai...


[style] ~420-~420: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...elSendToChain support from evm call. - [cronos#600](https://github.com/crypto-org-chai...


[style] ~421-~421: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...plement bidirectional token mapping. - [cronos#611](https://github.com/crypto-org-chai...


[style] ~422-~422: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...owledgement error in ibc middleware. - [cronos#627](https://github.com/crypto-org-chai...


[style] ~437-~437: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...leware, use ibc-go upstream version. - [cronos#550](https://github.com/crypto-org-chai...


[style] ~438-~438: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...basic json-rpc apis on pruned nodes. - [cronos#549](https://github.com/crypto-org-chai...


[style] ~439-~439: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...tom tx indexer feature of ethermint. - [cronos#673](https://github.com/crypto-org-chai...


[style] ~457-~457: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ed in json-rpc apis (backport #502). - [cronos#526](https://github.com/crypto-org-chai...


[style] ~458-~458: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... Fix tendermint duplicated tx issue. - [cronos#584](https://github.com/crypto-org-chai...


[style] ~459-~459: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...shes returned in some JSON-RPC apis. - [cronos#587](https://github.com/crypto-org-chai...


[style] ~460-~460: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... tx patch cmd recompute eth tx hash. - [cronos#595](https://github.com/crypto-org-chai...


[style] ~466-~466: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...nd to patch txs post v0.7.0 upgrade. - [cronos#522](https://github.com/crypto-org-chai...


[style] ~467-~467: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... the tendermint tx duplicated issue. - [cronos#585](https://github.com/crypto-org-chai...


[style] ~481-~481: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ase fee related logic in the code. - [ethermint#817](https://github.com/tharsis/ethermi...


[style] ~482-~482: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ogic related to effectiveGasPrice. - [ethermint#822](https://github.com/tharsis/ethermi...


[style] ~485-~485: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... tx when block gas limit exceeded. - [cosmos-sdk#10725](https://github.com/cosmos/cosmos...


[style] ~493-~493: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...e url query parameter in swagger-ui. - [cronos#328](https://github.com/crypto-org-chai...


[style] ~494-~494: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...query result when --trace enabled. - [cronos#441](https://github.com/crypto-org-chai...


[style] ~501-~501: ‘prior to’ might be wordy. Consider a shorter alternative. (EN_WORDINESS_PREMIUM_PRIOR_TO)
Context: ...ll/329) Fix panic of eth_call on blocks prior to upgrade. - [cronos#340](https://github....


[style] ~502-~502: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...eth_call on blocks prior to upgrade. - [cronos#340](https://github.com/crypto-org-chai...


[style] ~503-~503: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...t, b) fix data races traceContext. - [cronos#370](https://github.com/crypto-org-chai...


[style] ~504-~504: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...g, add websockets integration tests. - [cronos#378](https://github.com/crypto-org-chai...


[style] ~505-~505: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... add returnValue message on tracing. - [cronos#446](https://github.com/crypto-org-chai...


[grammar] ~625-~625: After ‘it’, use the third-person verb form “upgrades”. (IT_VBZ)
Context: ...org Chain. In addition to that, it also upgrade ethermint to its latest version (v0.5.0...


[uncategorized] ~663-~663: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ... version is a new scaffolding of cronos project where ethermint is included as a librar...

Markdownlint
CHANGELOG.md

53-53: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


65-65: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


73-73: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


81-81: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


89-89: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


90-90: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


91-91: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


95-95: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


103-103: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


104-104: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


105-105: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


106-106: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


107-107: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


108-108: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


112-112: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


113-113: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


119-119: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


120-120: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


121-121: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


122-122: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


123-123: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


127-127: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


128-128: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


129-129: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


130-130: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


131-131: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


132-132: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


136-136: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


137-137: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


138-138: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


139-139: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


140-140: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


141-141: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


145-145: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


146-146: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


147-147: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


155-155: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


156-156: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


160-160: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


168-168: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


169-169: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


170-170: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


171-171: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


172-172: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


173-173: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


174-174: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


175-175: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


176-176: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


177-177: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


178-178: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


179-179: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


180-180: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


181-181: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


182-182: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


183-183: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


184-184: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


185-185: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


186-186: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


187-187: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


188-188: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


189-189: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


190-190: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


191-191: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


192-192: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


196-196: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


197-197: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


198-198: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


199-199: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


200-200: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


201-201: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


202-202: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


203-203: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


204-204: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


205-205: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


206-206: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


207-207: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


208-208: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


209-209: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


210-210: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


211-211: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


215-215: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


216-216: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


217-217: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


218-218: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


219-219: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


220-220: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


221-221: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


222-222: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


226-226: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


227-227: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


228-228: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


229-229: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


230-230: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


231-231: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


232-232: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


233-233: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


234-234: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


235-235: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


236-236: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


237-237: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


238-238: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


239-239: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


240-240: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


241-241: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


242-242: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


243-243: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


244-244: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


245-245: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


246-246: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


247-247: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


248-248: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


249-249: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


250-250: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


258-258: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


259-259: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


260-260: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


264-264: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


265-265: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


266-266: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


267-267: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


268-268: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


269-269: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


270-270: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


278-278: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


286-286: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


290-290: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


291-291: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


292-292: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


300-300: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


304-304: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


305-305: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


306-306: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


314-314: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


322-322: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


330-330: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


331-331: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


340-340: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


348-348: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


356-356: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


364-364: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


365-365: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


366-366: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


367-367: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


375-375: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


383-383: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


384-384: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


392-392: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


396-396: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


397-397: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


398-398: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


406-406: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


418-418: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


419-419: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


420-420: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


421-421: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


422-422: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


423-423: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


424-424: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


428-428: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


429-429: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


430-430: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


434-434: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


435-435: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


436-436: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


437-437: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


438-438: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


439-439: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


447-447: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


455-455: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


456-456: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


457-457: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


458-458: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


459-459: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


460-460: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


464-464: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


465-465: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


466-466: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


467-467: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


475-475: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


476-476: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


477-477: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


478-478: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


479-479: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


480-480: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


481-481: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


482-482: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


483-483: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


484-484: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


485-485: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


486-486: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


490-490: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


491-491: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


492-492: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


493-493: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


494-494: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


498-498: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


499-499: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


500-500: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


501-501: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


502-502: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


503-503: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


504-504: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


505-505: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


513-513: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


514-514: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


522-522: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


530-530: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


531-531: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


532-532: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


536-536: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


537-537: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


545-545: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


546-546: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


547-547: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


548-548: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


549-549: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


557-557: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


561-561: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


562-562: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


563-563: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


564-564: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


574-574: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


578-578: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


579-579: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


580-580: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


581-581: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


585-585: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


586-586: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


597-597: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


598-598: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


599-599: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


600-600: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


601-601: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


605-605: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


606-606: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


607-607: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


617-617: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


618-618: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


629-629: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


633-633: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


634-634: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


635-635: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


636-636: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


637-637: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


638-638: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


640-640: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


641-641: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


649-649: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


653-653: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


657-657: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


667-667: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


668-668: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


669-669: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


670-670: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


676-676: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


677-677: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


681-681: Expected: asterisk; Actual: dash (MD004, ul-style)
Unordered list style


39-39: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


47-47: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


59-59: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


67-67: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


75-75: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


83-83: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


97-97: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


115-115: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


149-149: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


162-162: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


252-252: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


272-272: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


280-280: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


294-294: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


308-308: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


316-316: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


324-324: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


334-334: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


342-342: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


350-350: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


358-358: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


369-369: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


377-377: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


386-386: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


400-400: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


408-408: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


412-412: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


441-441: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


449-449: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


469-469: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


507-507: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


516-516: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


524-524: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


539-539: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


551-551: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


566-566: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


588-588: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


609-609: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


620-620: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


643-643: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading


659-659: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading

Additional comments not posted (2)
CHANGELOG.md (1)

27-27: Confirm the placement and formatting of the new entry.

The entry about enabling optimistic execution is correctly placed under the "Improvements" section. Ensure that it follows the same formatting as other entries for consistency.

app/app.go (1)

389-389: Confirm integration and implications of enabling optimistic execution by default.

This line enables optimistic execution by default, which can have significant impacts on transaction processing and state management. It's essential to ensure this change is well-tested and integrated seamlessly with the existing application logic.

Verification successful

Confirm integration and implications of enabling optimistic execution by default.

The change to enable optimistic execution by default is isolated to the configuration of baseAppOptions and does not introduce any breaking changes or side effects based on the current codebase usage.

  • baseAppOptions is used in various places, indicating its importance in configuring the application.
  • SetOptimisticExecution is only used in the specified line, with no direct dependencies or interactions elsewhere in the codebase.
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify that enabling optimistic execution does not introduce breaking changes or side effects.

# Test: Search for any issues related to optimistic execution in recent commits. Expect: No related issues.
rg --type go $'SetOptimisticExecution'

Length of output: 123



Script:

#!/bin/bash
# Description: Verify the usage of baseAppOptions and ensure no unintended side effects from enabling optimistic execution.

# Search for all usages of baseAppOptions to understand its scope and impact.
rg --type go 'baseAppOptions'

# Search for the definition and any additional usages of SetOptimisticExecution to check for dependencies or interactions.
rg --type go 'SetOptimisticExecution'

Length of output: 1226

@yihuang yihuang added this pull request to the merge queue Jun 26, 2024
Merged via the queue into crypto-org-chain:main with commit 2f021c3 Jun 26, 2024
50 checks passed
@yihuang yihuang deleted the enable-oe branch June 26, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants