Problem: invalid txs_results returned for legacy ABCI responses

[mmsqe]

For more info

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

• New Features

  • Introduced the ability to retrieve transactions via HTTP requests in integration tests.

• Bug Fixes

  • Improved port handling to ensure availability before proceeding with operations in integration tests.

• Chores

  • Updated github.com/cometbft/cometbft dependency to version v0.38.10-0.20240709120009-0792c8bdda44.

[coderabbitai]

Walkthrough

This update primarily concerns upgrading the dependency github.com/cometbft/cometbft to a newer version in both go.mod and gomod2nix.toml files. Additionally, the integration tests have been enhanced in integration_tests/test_upgrade.py with new functionalities and improvements in how ports are managed and transactions are retrieved.

Changes

Files	Change Summary
go.mod, gomod2nix.toml	Updated the version of github.com/cometbft/cometbft from v0.38.8 to v0.38.10-0.20240709120009-0792c8bdda44.
integration_tests/test_upgrade.py	Added get_txs function, revised port handling in exec and do_upgrade functions; ensures port availability.

Poem

In the code where bytes do flow,
Dependencies had room to grow.
From v0.38.8 we soar,
To v0.38.10 and more!
Ports are checked with care and glee,
Transactions flow, wild and free. 🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.87%. Comparing base (14572fa) to head (8324e23).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1485   +/-   ##
=======================================
  Coverage   35.87%   35.87%           
=======================================
  Files         136      136           
  Lines        9809     9809           
=======================================
  Hits         3519     3519           
  Misses       5894     5894           
  Partials      396      396           

[coderabbitai]

Actionable comments posted: 2

Outside diff range and nitpick comments (1)

integration_tests/test_upgrade.py (1)

164-164: Add comments to explain each step for better clarity.

The do_upgrade function would benefit from additional comments to explain the purpose of each step.

def do_upgrade(plan_name, target, mode=None):
    # Propose the upgrade
    rsp = cli.gov_propose_legacy(
        "community",
        "software-upgrade",
        {
            "name": plan_name,
            "title": "upgrade test",
            "description": "ditto",
            "upgrade-height": target,
            "deposit": "10000basetcro",
        },
        mode=mode,
    )
    assert rsp["code"] == 0, rsp["raw_log"]
    approve_proposal(c, rsp["logs"][0]["events"])

    # Update the CLI chain binary to the new version
    c.chain_binary = (
        Path(c.chain_binary).parent.parent.parent / f"{plan_name}/bin/cronosd"
    )
    # Wait for the block to pass the target height
    wait_for_block(c.cosmos_cli(), target + 2, timeout=480)
    wait_for_port(ports.rpc_port(base_port))

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 14572fa and 8324e23.

Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

Files selected for processing (3)

• go.mod (1 hunks)
• gomod2nix.toml (1 hunks)
• integration_tests/test_upgrade.py (9 hunks)

Files skipped from review due to trivial changes (2)

• go.mod
• gomod2nix.toml