Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: release workflow don't build x86 mac #1423

Merged
merged 1 commit into from
May 3, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented May 3, 2024

Because macos-latest becomes M1 mac now.

see: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

Solution:

  • update runner

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • Chores
    • Updated the macOS runner versions in the release workflow to include macOS-13 and macOS-14 for enhanced compatibility.

Because macos-latest becomes M1 mac now.

Solution:
- update runner
@yihuang yihuang requested a review from a team as a code owner May 3, 2024 06:15
@yihuang yihuang requested review from mmsqe and calvinaco and removed request for a team May 3, 2024 06:15
Copy link
Contributor

coderabbitai bot commented May 3, 2024

Walkthrough

The update in the GitHub Actions workflow configuration primarily adjusts the macOS runner versions used in the release process. The change shifts from using the macos-latest descriptor to specifically using macos-13, alongside the existing macos-14, optimizing compatibility and performance for the CI/CD pipeline.

Changes

File Path Change Summary
.github/.../release.yml Updated macOS runner versions from macos-latest, macos-14 to macos-13, macos-14

🐰✨
A hop, a skip, a code deploy,
In the land of Git, a joyous ploy.
From latest to thirteen, we roam,
Ensuring our code finds a perfect home.
Oh, how smoothly the workflows run,
Under the watchful eye of the macOS sun! 🌞🍏
🐇💻


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between cc44b30 and 0e88d49.
Files selected for processing (1)
  • .github/workflows/release.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/release.yml (1)

53-53: Update to macOS runner versions to ensure x86 architecture compatibility.

This change correctly updates the macOS runner versions from macos-latest to macos-13 and retains macos-14, aligning with the PR's objective to ensure compatibility with x86 architecture. Good job on specifying versions that support the required architecture.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

yihuang added a commit to yihuang/cronos that referenced this pull request May 3, 2024
…ain#1423)

Because macos-latest becomes M1 mac now.

Solution:
- update runner
@yihuang yihuang enabled auto-merge May 3, 2024 06:18
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.78%. Comparing base (cc44b30) to head (0e88d49).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1423       +/-   ##
===========================================
- Coverage   35.86%   17.78%   -18.09%     
===========================================
  Files         136       87       -49     
  Lines        9870     5337     -4533     
===========================================
- Hits         3540      949     -2591     
+ Misses       5934     4278     -1656     
+ Partials      396      110      -286     

see 72 files with indirect coverage changes

@yihuang yihuang added this pull request to the merge queue May 3, 2024
yihuang added a commit that referenced this pull request May 3, 2024
Because macos-latest becomes M1 mac now.

Solution:
- update runner
Merged via the queue into crypto-org-chain:main with commit 9aa7258 May 3, 2024
41 of 42 checks passed
yihuang added a commit that referenced this pull request May 3, 2024
* Problem: no parsed log from old event (#1416)

* Problem: no parsed log from old event

* update deps

* update doc

* cleanup

* Problem: v1.2.2 not releasd (#1422)

* Problem: release workflow don't build x86 mac (backport #1423) (#1424)

Because macos-latest becomes M1 mac now.

Solution:
- update runner

---------

Co-authored-by: mmsqe <[email protected]>
alienc0der pushed a commit to alienc0der/supernova that referenced this pull request Jun 8, 2024
Because macos-latest becomes M1 mac now.

Solution:
- update runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants