-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: release workflow don't build x86 mac #1423
Conversation
Because macos-latest becomes M1 mac now. Solution: - update runner
WalkthroughThe update in the GitHub Actions workflow configuration primarily adjusts the macOS runner versions used in the release process. The change shifts from using the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
…ain#1423) Because macos-latest becomes M1 mac now. Solution: - update runner
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1423 +/- ##
===========================================
- Coverage 35.86% 17.78% -18.09%
===========================================
Files 136 87 -49
Lines 9870 5337 -4533
===========================================
- Hits 3540 949 -2591
+ Misses 5934 4278 -1656
+ Partials 396 110 -286 |
9aa7258
* Problem: no parsed log from old event (#1416) * Problem: no parsed log from old event * update deps * update doc * cleanup * Problem: v1.2.2 not releasd (#1422) * Problem: release workflow don't build x86 mac (backport #1423) (#1424) Because macos-latest becomes M1 mac now. Solution: - update runner --------- Co-authored-by: mmsqe <[email protected]>
Because macos-latest becomes M1 mac now. Solution: - update runner
Because macos-latest becomes M1 mac now.
see: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit