Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: no exposed db keyring used in the keystore #1419

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

keep prefix

3cf11a2
Select commit
Loading
Failed to load commit list.
Open

Problem: no exposed db keyring used in the keystore #1419

keep prefix
3cf11a2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 3, 2024 in 0s

36.08% (+18.54%) compared to d41d670

View this Pull Request on Codecov

36.08% (+18.54%) compared to d41d670

Details

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 36.08%. Comparing base (d41d670) to head (3cf11a2).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1419       +/-   ##
===========================================
+ Coverage   17.54%   36.08%   +18.54%     
===========================================
  Files          87      136       +49     
  Lines        5273     9732     +4459     
===========================================
+ Hits          925     3512     +2587     
- Misses       4238     5822     +1584     
- Partials      110      398      +288     
Files Coverage Δ
x/e2ee/keyring/keyring.go 67.56% <47.36%> (+41.44%) ⬆️

... and 72 files with indirect coverage changes