Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some typos #1418

Merged
merged 2 commits into from
May 6, 2024
Merged

chore: fix some typos #1418

merged 2 commits into from
May 6, 2024

Conversation

clonemycode
Copy link
Contributor

@clonemycode clonemycode commented May 1, 2024

fix some typos

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • Documentation
    • Corrected typos in comments across multiple files to improve clarity and accuracy.

@clonemycode clonemycode requested a review from a team as a code owner May 1, 2024 17:17
@clonemycode clonemycode requested review from yihuang and devashishdxt and removed request for a team May 1, 2024 17:17
Copy link
Contributor

coderabbitai bot commented May 1, 2024

Walkthrough

The recent updates involve correcting typographical errors in comments and test descriptions across various files, ensuring clarity and professionalism in the codebase. These changes enhance communication accuracy within the project.

Changes

File Path Change Summary
app/app.go Corrected a typo in comments for IBC router modules.
integration_tests/test_basic.py Fixed a typo in a test case description.
nix/.../build_overlay.nix Updated comment typo from "nessesary" to "necessary".

🐰✨
In the code where we hop,
Typos caught, now they stop.
Clean and clear, on we go,
Through the files, high and low.
Cheers to clarity, hip hip hooray! 🎉
🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yihuang
Copy link
Collaborator

yihuang commented May 2, 2024

@clonemycode can you sign the commit?

Signed-off-by: clonemycode <[email protected]>
@clonemycode
Copy link
Contributor Author

@clonemycode can you sign the commit?

Of course. Signed

@yihuang yihuang enabled auto-merge May 6, 2024 06:58
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.82%. Comparing base (9aa7258) to head (585ad54).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1418       +/-   ##
===========================================
+ Coverage   17.78%   34.82%   +17.04%     
===========================================
  Files          87      136       +49     
  Lines        5337     9870     +4533     
===========================================
+ Hits          949     3437     +2488     
- Misses       4278     6071     +1793     
- Partials      110      362      +252     

see 78 files with indirect coverage changes

@yihuang yihuang added this pull request to the merge queue May 6, 2024
Merged via the queue into crypto-org-chain:main with commit 5ba9b8c May 6, 2024
45 checks passed
alienc0der pushed a commit to alienc0der/supernova that referenced this pull request Jun 8, 2024
Signed-off-by: clonemycode <[email protected]>
Co-authored-by: yihuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants