Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: lorri is not as convinient as nix-direnv #1335

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Mar 5, 2024

Solution:

  • use nix-direnv, very fast, and don't need to run a daemon.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • Chores
    • Updated the environment setup method for improved efficiency and reliability.

@yihuang yihuang marked this pull request as ready for review March 5, 2024 03:22
@yihuang yihuang requested a review from a team as a code owner March 5, 2024 03:22
@yihuang yihuang requested review from JayT106 and calvinaco and removed request for a team March 5, 2024 03:22
Copy link
Contributor

coderabbitai bot commented Mar 5, 2024

Walkthrough

This update represents a pivotal transformation in the project's environment setup approach, shifting from lorri direnv to leveraging use flake for environment setup. Moreover, it establishes TMPDIR as /tmp, promoting consistency and reliability across diverse development contexts.

Changes

File Change Summary
.envrc Transitioned from lorri direnv to use flake; Configured TMPDIR to /tmp

🐇✨
In the realm of code, under the moon's soft gaze,
A rabbit hopped, leaving behind old ways.
"Use flake," it whispered, with a twinkle in its eye,
"And let /tmp be your guide under the vast sky."
With every hop, a new path it did chart,
In the world of code, a fresh start.
🌟🌿

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@yihuang yihuang requested a review from mmsqe March 5, 2024 03:22
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e9bb006 and 3f4aefc.
Files selected for processing (1)
  • .envrc (1 hunks)
Additional comments: 1
.envrc (1)
  • 2-2: Setting TMPDIR to /tmp is a common practice, but it's important to consider security implications and system-specific configurations, especially on shared systems or systems with limited /tmp space.

Consider reviewing the security policies regarding temporary file storage and ensuring that this setting does not conflict with system-specific configurations or limitations.

.envrc Show resolved Hide resolved
@yihuang yihuang enabled auto-merge March 5, 2024 03:34
@yihuang yihuang force-pushed the multi-accounts-bench branch from 3f4aefc to ada5c6e Compare March 5, 2024 04:16
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e9bb006 and ada5c6e.
Files selected for processing (1)
  • .envrc (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .envrc

@yihuang yihuang added this pull request to the merge queue Mar 5, 2024
Merged via the queue into crypto-org-chain:main with commit abc1ea6 Mar 5, 2024
34 checks passed
@yihuang yihuang deleted the multi-accounts-bench branch March 5, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants