-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: versiondb version mismatch related fixes are not backported #1306
Problem: versiondb version mismatch related fixes are not backported #1306
Conversation
…chain#1302) * Problem: memiavl rootmulti store access map concurrently Solution: - code refactoring * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> --------- Signed-off-by: yihuang <[email protected]>
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
* Problem: versiondb lag behind when os reboot Closes: crypto-org-chain#1301 Solution: - do fsync when writing versiondb * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * relax version checking * changelog --------- Signed-off-by: yihuang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/memiavl/v0.0.x #1306 +/- ##
==========================================================
+ Coverage 46.46% 46.47% +0.01%
==========================================================
Files 105 105
Lines 7935 7937 +2
==========================================================
+ Hits 3687 3689 +2
Misses 3866 3866
Partials 382 382
|
c12016e
into
crypto-org-chain:release/memiavl/v0.0.x
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
backport #1302 #1304
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)