Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: rocksdb cause high memory consumption (port: #1197) #1210

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Oct 16, 2023

  • Problem: rocksdb cause high memory consumption

  • bump librocksdb

  • remove fork

  • changelog

  • fix lint

  • Apply suggestions from code review

  • Update x/cronos/keeper/mock/ibckeeper_mock.go

  • update deps


👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

* Problem: rocksdb cause high memory consumption

* bump librocksdb

* remove fork

* changelog

* fix lint

* Apply suggestions from code review

Signed-off-by: yihuang <[email protected]>

* Update x/cronos/keeper/mock/ibckeeper_mock.go

Co-authored-by: mmsqe <[email protected]>
Signed-off-by: yihuang <[email protected]>

* update deps

---------

Signed-off-by: yihuang <[email protected]>
Co-authored-by: mmsqe <[email protected]>
@yihuang yihuang requested a review from a team as a code owner October 16, 2023 11:40
@yihuang yihuang requested review from mmsqe and JayT106 and removed request for a team October 16, 2023 11:40
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
go.mod Show resolved Hide resolved
@yihuang yihuang changed the title Problem: rocksdb cause high memory consumption (#1197) Problem: rocksdb cause high memory consumption (port: #1197) Oct 16, 2023
@mmsqe mmsqe added this pull request to the merge queue Oct 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2023
@mmsqe mmsqe added this pull request to the merge queue Oct 16, 2023
Merged via the queue into crypto-org-chain:main with commit 51534df Oct 16, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants