-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: v1.1.0 dependency changelog not reviewed #1194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
changed the title
Problem: v1.1.0 changelog not reviewed
Problem: v1.1.0 dependency changelog not reviewed
Oct 5, 2023
yihuang
requested review from
calvinaco,
thomas-nguy,
lezzokafka and
mmsqe
and removed request for
a team
October 5, 2023 01:52
mmsqe
reviewed
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and we bumped up ibc-go as well
mmsqe
approved these changes
Oct 5, 2023
yihuang
commented
Oct 9, 2023
Signed-off-by: yihuang <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1194 +/- ##
===========================================
+ Coverage 16.70% 36.95% +20.25%
===========================================
Files 79 115 +36
Lines 5766 10235 +4469
===========================================
+ Hits 963 3782 +2819
- Misses 4725 6080 +1355
- Partials 78 373 +295 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)