Problem: relayer doesn't make use of binding contract #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmsqe
changed the title
mmsqe
commented
Oct 5, 2023
Signed-off-by: mmsqe <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+47
to
+60
| for methodName, _ := range irelayerABI.Methods { | ||
| var methodID [4]byte | ||
| copy(methodID[:], irelayerABI.Methods[methodName].ID[:4]) | ||
| switch methodName { | ||
| case CreateClient: | ||
| relayerGasRequiredByMethod[methodID] = 200000 | ||
| case RecvPacket, Acknowledgement: | ||
| relayerGasRequiredByMethod[methodID] = 250000 | ||
| case UpdateClient, UpgradeClient: | ||
| relayerGasRequiredByMethod[methodID] = 400000 | ||
| default: | ||
| relayerGasRequiredByMethod[methodID] = 100000 | ||
| } | ||
| } |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m Error
Comment on lines
+47
to
+60
| for methodName, _ := range irelayerABI.Methods { | ||
| var methodID [4]byte | ||
| copy(methodID[:], irelayerABI.Methods[methodName].ID[:4]) | ||
| switch methodName { | ||
| case CreateClient: | ||
| relayerGasRequiredByMethod[methodID] = 200000 | ||
| case RecvPacket, Acknowledgement: | ||
| relayerGasRequiredByMethod[methodID] = 250000 | ||
| case UpdateClient, UpgradeClient: | ||
| relayerGasRequiredByMethod[methodID] = 400000 | ||
| default: | ||
| relayerGasRequiredByMethod[methodID] = 100000 | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1193 +/- ##
===========================================
+ Coverage 16.73% 36.43% +19.70%
===========================================
Files 79 116 +37
Lines 5766 10374 +4608
===========================================
+ Hits 965 3780 +2815
- Misses 4723 6220 +1497
- Partials 78 374 +296
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)