Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: event converter don't have to be global #1164

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Sep 13, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #1164 (baf5456) into main (4f11310) will increase coverage by 14.84%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1164       +/-   ##
===========================================
+ Coverage   33.57%   48.42%   +14.84%     
===========================================
  Files         113       73       -40     
  Lines       11064     6125     -4939     
===========================================
- Hits         3715     2966      -749     
+ Misses       6980     2846     -4134     
+ Partials      369      313       -56     

see 51 files with indirect coverage changes

@mmsqe mmsqe marked this pull request as ready for review September 13, 2023 08:40
@mmsqe mmsqe requested a review from a team as a code owner September 13, 2023 08:40
@mmsqe mmsqe requested review from yihuang and calvinaco and removed request for a team September 13, 2023 08:40
@mmsqe mmsqe enabled auto-merge September 13, 2023 08:42
@mmsqe mmsqe added this pull request to the merge queue Sep 13, 2023
Merged via the queue into crypto-org-chain:main with commit a376154 Sep 13, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants