-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: no stateful precompiled contract for ica #1163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1163 +/- ##
==========================================
- Coverage 38.53% 37.61% -0.93%
==========================================
Files 115 114 -1
Lines 9810 10077 +267
==========================================
+ Hits 3780 3790 +10
- Misses 5652 5907 +255
- Partials 378 380 +2
|
mmsqe
requested review from
JayT106 and
devashishdxt
and removed request for
a team
September 12, 2023 02:54
thomas-nguy
reviewed
Sep 13, 2023
JayT106
reviewed
Sep 13, 2023
mmsqe
force-pushed
the
ica_precompile
branch
from
September 14, 2023 06:28
90131dd
to
9dad29e
Compare
fix decode
mmsqe
force-pushed
the
ica_precompile
branch
2 times, most recently
from
September 16, 2023 01:24
692232c
to
d2d7c20
Compare
mmsqe
force-pushed
the
ica_precompile
branch
from
September 18, 2023 01:03
d2d7c20
to
2247df5
Compare
mmsqe
force-pushed
the
ica_precompile
branch
from
September 18, 2023 01:51
2247df5
to
9a7a697
Compare
mmsqe
force-pushed
the
ica_precompile
branch
from
September 18, 2023 04:05
d2363b9
to
766071f
Compare
mmsqe
force-pushed
the
ica_precompile
branch
from
September 22, 2023 05:21
096bd49
to
32d9db6
Compare
mmsqe
force-pushed
the
ica_precompile
branch
from
September 22, 2023 06:39
32d9db6
to
50923db
Compare
calvinaco
reviewed
Sep 22, 2023
calvinaco
reviewed
Sep 22, 2023
yihuang
reviewed
Sep 25, 2023
yihuang
reviewed
Sep 25, 2023
yihuang
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, two minor suggestions:
- use new method
CacheContext
to execute queries - maybe remove default decoder, and make converted attributes explicit.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 25, 2023
Merged
via the queue into
crypto-org-chain:main
with commit Sep 25, 2023
3313f54
29 of 32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)