Apply suggestions from code review

crypto-org-chain · Feb 28, 2024 · 9fd2170 · 9fd2170
1 parent f31dc65
commit 9fd2170
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## UNRELEASED
+
+### Bug Fixes
+
+- [#1329](https://github.com/crypto-org-chain/cronos/pull/1329) Update cosmos-sdk to `v0.47.10`.
+
 *February 19, 2024*
 
 ## v1.1.0-rc4

diff --git a/integration_tests/test_client_id.py → integration_tests/test_chain_id.py b/integration_tests/test_client_id.py → integration_tests/test_chain_id.py
@@ -1,5 +1,6 @@
 import json
 
+import pytest
 from pystarport import ports
 
 from .utils import wait_for_block, wait_for_port
@@ -26,12 +27,8 @@ def assert_chain_id(chain_id, timeout=None):
         if timeout is None:
             wait_for_block(cli, height)
         else:
-            try:
-                print(f"should assert timeout err when pass {timeout}s")
+            with pytest.raises(TimeoutError):
                 wait_for_block(cli, height, timeout)
-            except TimeoutError:
-                raised = True
-            assert raised
 
     assert_chain_id(776, 5)
     cronos.supervisorctl("stop", n0)