Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem] missing document for dynamic contract in unreal engine plugin (fix #286) #288

Open
wants to merge 13 commits into
base: gitbook
Choose a base branch
from

Conversation

leejw51crypto
Copy link
Contributor

Solution: add document for dynamic contract

@leejw51crypto leejw51crypto requested a review from a team as a code owner December 20, 2022 07:04
@ricky321q
Copy link

For those blueprint png, should we also export those blueprint code, so people could copy & paste?

@leejw51crypto
Copy link
Contributor Author

ok, i'll include blueprint code

Copy link
Contributor

@rarcif rarcif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is applicable right nor or necessary, I was wondering if we could position the blueprints in a sorted way to make the relations appear cleaner. *e.g. like in this screenshot)
Screenshot 2022-12-20 at 11 46 54 AM

For the function arguments, I am not sure if this is placeholder data, but maybe we could use constants like MY_TEST_ADDRESS, MY_TEST_DATA. Just an idea.

```
- function arguments:
```
[{"Address":{"data":"0x00"}},{"Str":{"data":"my"}}]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this placeholder data?

Copy link
Contributor Author

@leejw51crypto leejw51crypto Dec 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not only placeholder also gives correct type.
this is for json encoding for function argument.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's given as json, and restored as solidity arguments

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@leejw51crypto leejw51crypto marked this pull request as draft December 20, 2022 10:46
@leejw51crypto
Copy link
Contributor Author

interface will be changed, so changed to draft

crypto-org-chain#286

add category

fix typo

fix typo

add text

add send blueprint

add encode

add call

add api

fix link

fix typo

update
@leejw51crypto
Copy link
Contributor Author

updated

@leejw51crypto leejw51crypto marked this pull request as ready for review January 6, 2023 05:56
@damoncro
Copy link
Contributor

Would you add WalletConnect examples? Connect with real wallets and use dynamic contracts feature.

@damoncro
Copy link
Contributor

damoncro commented Jan 10, 2023

To better connect with other sections, especially
image
It is good to add some words on the relationships between DefiWalletCoreActor and DynamicContractObject. So that the users know where Defi Wallet comes from, and how they create Dynamic Contract Object.

For example,

To use Dynamic Contract feature, we have to create a DynamicContractObject. DynamicContractObject is an UObject that is created by CreateDynamicSigningContract or CreateDynamicContract from DefiWalletCoreActor.

@leejw51crypto
Copy link
Contributor Author

ok, i'll add wallet-connect example and modify

@rarcifa
Copy link

rarcifa commented Jan 11, 2023

@leejw51crypto I Just noticed an unsigned commit from the 5th of January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants