perf: Make recheck not re-run validate basic (backport: #20208) #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
915
to
+923
| } | ||
|
|
||
| msgs := tx.GetMsgs() | ||
| if err := validateBasicTxMsgs(msgs); err != nil { | ||
| return sdk.GasInfo{}, nil, nil, err | ||
| // run validate basic if mode != recheck. | ||
| // as validate basic is stateless, it is guaranteed to pass recheck, given that its passed checkTx. | ||
| if mode != execModeReCheck { | ||
| if err := validateBasicTxMsgs(msgs); err != nil { | ||
| return sdk.GasInfo{}, nil, nil, err | ||
| } |
There was a problem hiding this comment.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).runTxWithMultiStore (baseapp/baseapp.go:851)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).deliverTxWithMultiStore (baseapp/baseapp.go:777)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).executeTxs (baseapp/baseapp.go:854)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).internalFinalizeBlock (baseapp/baseapp.go:700)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).FinalizeBlock (baseapp/baseapp.go:903)
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
yihuang
approved these changes
Nov 25, 2024
Signed-off-by: yihuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...