Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: cannot unmarshal gov param into a *big.Int #857

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Oct 14, 2024

Description

  • when use back LegacyDec
  • since main branch skip any cosmossdk.io/math.LegacyDec value,
  • no need to unmarshal here, for more info

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

mmsqe added 2 commits October 14, 2024 17:11
* when use back LegacyDec, since main branch skip any cosmossdk.io/math.LegacyDec value,
* no need to unmarshal here, for more info:
	https://github.com/cosmos/cosmos-sdk/blob/4274dcf4429cc725a3bda58410bd8325d721a3e9/x/tx/signing/aminojson/options.go#L134
@mmsqe mmsqe force-pushed the release/v0.50.x_dec branch from 7605454 to d4f5265 Compare October 15, 2024 01:04
@mmsqe mmsqe marked this pull request as ready for review October 15, 2024 01:28
@mmsqe mmsqe requested a review from yihuang October 15, 2024 01:29
@yihuang yihuang merged commit 783e224 into crypto-org-chain:release/v0.50.x Oct 15, 2024
47 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants