Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: x/tx not up to date to the released version #279

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Apr 10, 2024

Solution:

  • catchup to the x/tx/0.13.1 first before further patching.

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@yihuang yihuang requested a review from mmsqe April 10, 2024 03:16
Solution:
- reset to the x/tx/0.13.1
@yihuang yihuang enabled auto-merge (squash) April 10, 2024 03:23
@yihuang yihuang merged commit b2be50d into crypto-org-chain:release/v0.50.x Apr 10, 2024
44 of 48 checks passed
@yihuang yihuang deleted the revert-tx branch April 10, 2024 03:38
x.Timestamp = value.Message().Interface().(*timestamppb.Timestamp)
default:
if fd.IsExtension() {
panic(fmt.Errorf("proto3 declared messages do not support extensions: testpb.Duration"))

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning test

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
if fd.IsExtension() {
panic(fmt.Errorf("proto3 declared messages do not support extensions: testpb.Duration"))
}
panic(fmt.Errorf("message testpb.Duration does not contain field %s", fd.FullName()))

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning test

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants