-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cosmos gRPC docs #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The docs in the
In this case, we might have to generate these files one by one
This might probably require us to include all third-party definitions, this file might extremely large I think. |
I agree with @eddycpc , I think we can leave the doc this way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other hand, I think it is better to crate a simple scripts for generating the docs. That way everyone can generate it in the future.
/staging |
I see. Sure if it's just for reference 👯 |
This is a good suggestion, I thought about this too but I realized it would be cool if that automation script can be done in a separate PR to keep this one small and focused on a single task. That task to add an automated script to download the latest gRPC definitions and generate a new doc file can be a separate task on its own I believe |
Sure, feel free to start a separated issue for that. |
Related to #33 |
cosmos-grpc-docs.md
file is a tool generated file